Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hass-cli wrapper sucks #9

Open
StayPirate opened this issue Dec 2, 2023 · 0 comments
Open

hass-cli wrapper sucks #9

StayPirate opened this issue Dec 2, 2023 · 0 comments

Comments

@StayPirate
Copy link
Owner

The hass-cli command is located at .local/bin/hass-cli. It directly runs a container without performing any check before. It just creates the container in case it doesn't exist yet.

Some check that needs to be added are:

  • is podman installed
  • because the container image is local, does it exist?

Moreover zsh eval hass-cli (!) in order to load auto-completion.

dotfiles/.zshrc

Line 182 in d0985b6

eval "$(_HASS_CLI_COMPLETE=zsh_source hass-cli)"

This is very bad because the wrapper is not meant to return an output that can be used with eval.

hass-cli was introduced at d0985b6.
Instead of fixing it I could also consider/research to replace it with sth better maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant