Skip to content

Commit 91e2d4e

Browse files
authored
Make skipped tests appear on test summary instead of hiding them entirely (#1641)
1 parent ca23480 commit 91e2d4e

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/Common/test/TestResources/FactSkippedOnPlatformAttribute.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ public FactSkippedOnPlatformAttribute(params string[] platformNames)
2323
{
2424
foreach (OSPlatform platform in platformNames.Select(OSPlatform.Create))
2525
{
26-
Assert.SkipWhen(RuntimeInformation.IsOSPlatform(platform), $"Skipping test on platform {platform}.");
26+
if (RuntimeInformation.IsOSPlatform(platform))
27+
{
28+
Skip = $"Skipping test on incompatible platform {platform}.";
29+
break;
30+
}
2731
}
2832
}
2933
}

src/Common/test/TestResources/TheorySkippedOnPlatformAttribute.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ public TheorySkippedOnPlatformAttribute(params string[] platformNames)
2323
{
2424
foreach (OSPlatform platform in platformNames.Select(OSPlatform.Create))
2525
{
26-
Assert.SkipWhen(RuntimeInformation.IsOSPlatform(platform), $"Skipping test on platform {platform}.");
26+
if (RuntimeInformation.IsOSPlatform(platform))
27+
{
28+
Skip = $"Skipping test on incompatible platform {platform}.";
29+
break;
30+
}
2731
}
2832
}
2933
}

0 commit comments

Comments
 (0)