diff --git a/README.md b/README.md index 9029d20..f3d7cb5 100644 --- a/README.md +++ b/README.md @@ -273,3 +273,18 @@ $manager->extend('custom_connection_name', function ($config) { // get an instance of your custom connection $pubsub = $manager->connection('custom_connection_name'); ``` + +## Contributing + +### Running Tests + +Run `composer install` to ensure local installation of dependencies. + +Run `make tests` to run test suite. + +If you need to run Kafka tests, install the Kafka bridge (note you still need to install the C library and PHP extension +separately): + +```bash +composer require superbalist/php-pubsub-kafka +``` \ No newline at end of file diff --git a/tests/PubSubConnectionFactoryTest.php b/tests/PubSubConnectionFactoryTest.php index e2dcebe..843a32f 100644 --- a/tests/PubSubConnectionFactoryTest.php +++ b/tests/PubSubConnectionFactoryTest.php @@ -126,14 +126,14 @@ public function testMakeKafkaAdapter() ->with($topicConf) ->once(); - $container->shouldReceive('make') + $container->shouldReceive('makeWith') ->with('pubsub.kafka.conf') ->once() ->andReturn($conf); $consumer = Mockery::mock(\RdKafka\KafkaConsumer::class); - $container->shouldReceive('make') + $container->shouldReceive('makeWith') ->withArgs([ 'pubsub.kafka.consumer', ['conf' => $conf],