Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files not attached to new tickets when message is empty #218

Open
iandunn opened this issue Aug 18, 2014 · 4 comments · May be fixed by #230
Open

Files not attached to new tickets when message is empty #218

iandunn opened this issue Aug 18, 2014 · 4 comments · May be fixed by #230

Comments

@iandunn
Copy link
Contributor

iandunn commented Aug 18, 2014

  1. Start a new ticket
  2. Upload a file
  3. Send the message

After the page refreshes, the files area is empty, and the file is not attached to the ticket. It does get displayed in the files area when uploading to an existing ticket, but not to a new one.

@iandunn iandunn added the bug label Aug 18, 2014
@VarunAgw
Copy link
Contributor

Just confirming it only happens if you leave reply textarea empty?

@iandunn
Copy link
Contributor Author

iandunn commented Aug 19, 2014

Yes, only if the message area is empty.

@iandunn iandunn changed the title Files not attached to new tickets Files not attached to new tickets when message is empty Aug 19, 2014
@iandunn
Copy link
Contributor Author

iandunn commented Sep 10, 2014

This looks good, the reply was added and the file was attached. I think it needs two adjustments, though:

  1. If the agent has the signature option enabled, then the signature should be added even if they leave the message empty
  2. An e-mail notification should be sent if a file is attached, even if the message is empty

The agent could want to send an email with an empty body, but with a file attached and their signature included.

@VarunAgw
Copy link
Contributor

Ok. I'll update it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants