Skip to content

Commit c7cbc91

Browse files
authored
Merge pull request #140 from Susanghan-guys/develop
release: 운영 μ„œλ²„μ— ν˜„μž¬κΉŒμ§€μ˜ μ§„ν–‰ 상황 반영
2 parents fe031cd + adbaf19 commit c7cbc91

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

β€Žsrc/main/java/com/susanghan_guys/server/mail/application/MailService.javaβ€Ž

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ public void sendMail() {
5858
}
5959

6060
private void sendWorkMembers(Work work, String template) {
61-
personalizeMail(new MailRequest(
61+
personalizeMail(MailRequest.of(
6262
work.getUser().getEmail(),
6363
work.getUser().getName(),
6464
work.getTitle(),
65-
generateUserLink(work),
65+
generateLink(work),
6666
work.getCode(),
6767
"[%s] μˆ˜μƒ 리포트 μ™„μ„± μ•ˆλ‚΄".formatted(work.getTitle())
6868
), template);
@@ -71,11 +71,11 @@ private void sendWorkMembers(Work work, String template) {
7171
if (work.getUser().getEmail().equals(workMember.getTeamMember().getEmail())) {
7272
continue;
7373
}
74-
personalizeMail(new MailRequest(
74+
personalizeMail(MailRequest.of(
7575
workMember.getTeamMember().getEmail(),
7676
workMember.getTeamMember().getName(),
7777
work.getTitle(),
78-
generateWorkMemberLink(work),
78+
generateLink(work),
7979
work.getCode(),
8080
"[%s] μˆ˜μƒ 리포트 μ™„μ„± μ•ˆλ‚΄".formatted(work.getTitle())
8181
), template);
@@ -104,14 +104,10 @@ private void personalizeMail(MailRequest request, String template) {
104104
}
105105
}
106106

107-
private String generateUserLink(Work work) {
107+
private String generateLink(Work work) {
108108
return redirectUri + work.getId();
109109
}
110110

111-
private String generateWorkMemberLink(Work work) {
112-
return redirectUri + work.getId() + "/verify-code";
113-
}
114-
115111
private String generateCode() {
116112
return UUID.randomUUID().toString().substring(0, 6).toUpperCase();
117113
}

β€Žsrc/main/java/com/susanghan_guys/server/mail/dto/request/MailRequest.javaβ€Ž

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,14 @@ public record MailRequest(
1111
String code,
1212
String subject
1313
) {
14+
public static MailRequest of(String mail, String name, String title, String link, String code, String subject) {
15+
return MailRequest.builder()
16+
.mail(mail)
17+
.name(name)
18+
.title(title)
19+
.link(link)
20+
.code(code)
21+
.subject(subject)
22+
.build();
23+
}
1424
}

β€Žsrc/main/java/com/susanghan_guys/server/work/dto/response/ReportInfoResponse.javaβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ public record ReportInfoResponse(
2222
@Schema(description = "곡λͺ¨μ „ νŒ€μ›", example = "[\"κΉ€μ² μˆ˜\", \"μ£Όμ •λΉˆ\", \"κ°•μˆ˜μ§„\"]")
2323
List<String> workMembers,
2424

25+
@Schema(description = "ν”Όλ“œλ°± μ—¬λΆ€", example = "false")
2526
boolean hasFeedback
2627
) {
2728
public static ReportInfoResponse from(Work work, boolean hasFeedback) {

0 commit comments

Comments
Β (0)