This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Migrate to Generator models #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of DocSet generation
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67
Resolves #27
Adding support for DocSet generation (#27) gives us a good opportunity to revisit the original implementation for the
generatesubcommand. Ad hoc use ofifandswitchstatements work well enough for alternating between 2 formats, but that breaks down for 3 or more.Now, all generators are unified around a single, common interface:
swift-doc/Sources/swift-doc/Supporting Types/Generator.swift
Line 4 in 57605fc
As for the DocSet generation itself, the HTML and search index are functional, but need some fine-tuning. CSS routing should work after merging #93.