Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Handle name collisions with special wiki page names (Home, _Sidebar, _Footer) #59

Open
mattt opened this issue Apr 7, 2020 · 1 comment
Open

Handle name collisions with special wiki page names (Home, _Sidebar, _Footer) #59

mattt opened this issue Apr 7, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mattt
Copy link
Contributor

mattt commented Apr 7, 2020

If a public type is named Home, _Sidebar, or _Footer, its generated documentation would be overwritten by the special page of the same name. We should add logic in the generate subcommand to handle this possibility.
@mattt mattt added bug Something isn't working good first issue Good for newcomers labels Apr 7, 2020
@mattt mattt changed the title Handle Name Collisions with Special Wiki Page Names (Home, _Sidebar, _Footer) Handle name collisions with special wiki page names (Home, _Sidebar, _Footer) Apr 7, 2020
@mattt
Copy link
Contributor Author

mattt commented Sep 25, 2020

Since this is unlikely to happen and it's unclear what the correct should be, the best course of action would be to log a warning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattt