Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to serialise csvw to file #31

Closed
Robsteranium opened this issue Jun 5, 2018 · 2 comments
Closed

Option to serialise csvw to file #31

Robsteranium opened this issue Jun 5, 2018 · 2 comments

Comments

@Robsteranium
Copy link
Contributor

With #27 we're now passing the json metadata to csv2rdf with an in-memory map (rather than writing it out to disk). This is designed to make the whole process more memory efficient when called via grafter-server/ pmd.

Ideally we would also support the original use case - so that people could use table2qb as a standalone, writing the csvw output (i.e json and csv files). This would allow users to pick a different csv2rdf implementation, or to target csvw itself.

@Robsteranium
Copy link
Contributor Author

Not being able to do this means the examples need to be updated by hand - I'm only worrying about those used in the tests for now.

Once the above is solved we ought to think about adding an "update examples" task or script.

Robsteranium added a commit that referenced this issue Aug 7, 2018
Update to codelist-pipeline; fixes #63.

Note that only the csvw involved in the tests has been changed (see #31).
Robsteranium added a commit that referenced this issue Aug 8, 2018
Fixes #65

Examples not updated owing to #31
lkitching added a commit that referenced this issue Apr 16, 2020
Issue #31 - Update each pipeline to output CSVW to the specified
directory instead of generating the output RDF directly. Update
the exec task to write the CSVW to a temporary directory and
write the RDF using csv2rdf. The cube pipeline now only creates
a single metadata file instead of one for each element (e.g. dataset
metadata, DSD etc.). Update each metadata function in the cube
namespace to return a table definition instead of a full metadata
definition by removing the @context key.

Add new csvw task which writes the CSVW output for each pipeline
to the specified directory.

Update the output of the describe task to include an example
invocation of the csvw command.
@Robsteranium
Copy link
Contributor Author

This is closed by #120, thanks @lkitching.

I've opened PR #123 extending on this to add a script that updates the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant