Skip to content

Commit

Permalink
chore(core): remove dependency on gitdb/gitdb2 (#1525)
Browse files Browse the repository at this point in the history
* chore(core): remove dependency on gitdb/gitdb2
  • Loading branch information
mohammad-alisafaee authored Sep 16, 2020
1 parent 458ddb9 commit b917e5c
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 49 deletions.
83 changes: 38 additions & 45 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions renku/core/management/git.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from pathlib import Path

import attr
import gitdb
import git

from renku.core import errors
from renku.core.utils.urls import remove_credentials
Expand Down Expand Up @@ -219,7 +219,7 @@ def ensure_unstaged(self, path):
if is_parent or is_equal:
raise errors.DirtyRenkuDirectory(self.repo)

except gitdb.exc.BadName:
except git.exc.BadName:
pass

def setup_credential_helper(self):
Expand Down Expand Up @@ -297,7 +297,7 @@ def commit(self, commit_only=None, commit_empty=True, raise_if_empty=False, comm
diffs = [d.a_path for d in self.repo.index.diff("HEAD")]
if project_metadata_path in diffs:
diffs.remove(project_metadata_path)
except gitdb.exc.BadName:
except git.exc.BadName:
pass

if not commit_empty and not diffs:
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ def run(self):
"flask==1.1.2",
"flask-apispec==0.10.0",
"flask-swagger-ui==3.25.0",
"gitdb2==3.0.1",
"gitpython==3.1.0",
"humanize>=2.5.0,<2.7.0",
"jinja2>=2.10.3,<=2.11.2",
Expand Down

0 comments on commit b917e5c

Please sign in to comment.