bug(web): handle edge case with dragging an event to very bottom of the page, causing event to overflow past container. Refactor code

this occurs when we drag an event to the very bottom until the event's end time is past midnight, instead of preventing me from dragging the event past midnight, the event overflows past its container.

Author: that-one-arab

packages/web/src/views/Calendar/components/Draft/hooks/actions/useDraftActions.ts

@@ -161,29 +161,33 @@ export const useDraftActions = (
       const updateTimesDuringDrag = (e: MouseEvent) => {
         setDraft((_draft) => {
           const x = getX(e, isSidebarOpen);
-          const _initialStart = dateCalcs.getDateByXY(
+          const startEndDurationMin = dragStatus?.durationMin || 0;
+
+          let eventStart = dateCalcs.getDateByXY(
             x,
             e.clientY,
             weekProps.component.startOfView,
           );
 
-          const startDate = _draft?.isAllDay
-            ? _initialStart.format(YEAR_MONTH_DAY_FORMAT)
-            : _initialStart.format();
-
-          const _end = _initialStart.add(
-            dragStatus?.durationMin || 0,
-            "minutes",
-          );
+          let eventEnd = eventStart.add(startEndDurationMin, "minutes");
 
-          const endDate = _draft.isAllDay
-            ? _end.format(YEAR_MONTH_DAY_FORMAT)
-            : _end.format();
+          if (!_draft.isAllDay) {
+            // Edge case: timed events' end times can overflow past midnight at the bottom of the grid.
+            // Below logic prevents that from occurring.
+            if (eventEnd.date() !== eventStart.date()) {
+              eventEnd = eventEnd.hour(0).minute(0);
+              eventStart = eventEnd.subtract(startEndDurationMin, "minutes");
+            }
+          }
 
           return {
             ..._draft,
-            startDate,
-            endDate,
+            startDate: _draft.isAllDay
+              ? eventStart.format(YEAR_MONTH_DAY_FORMAT)
+              : eventStart.format(),
+            endDate: _draft.isAllDay
+              ? eventEnd.format(YEAR_MONTH_DAY_FORMAT)
+              : eventEnd.format(),
             priority: _draft?.priority || Priorities.UNASSIGNED,
           };
         });