Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using unique identifier when receiving Gcal notification #105

Open
ondrejmoris opened this issue May 28, 2024 · 1 comment
Open

Not using unique identifier when receiving Gcal notification #105

ondrejmoris opened this issue May 28, 2024 · 1 comment

Comments

@ondrejmoris
Copy link

Hi, i checked your codebase and i probably found an issue. I am not sure about that, so i'm gonna mark this as question.

When you receive notification from google (web_hook) you recognize a user and a calendar by resource id but i think you need to recognize by resource id and channel id.

What would happen if two users had connected same google calendars but with different event permissions? I think resourced id would be same. I think resource id is specific only for calendars not for google account and calendar.

@tyler-dane
Copy link
Contributor

Hey @ondrejmoris, thanks for taking to time to document this. I think you're right about the resource id not being a sufficiently safe method to associate a calendar with a user. In fact, I think I went down the path of handling for this error with the findCalendarId() in sync.utils.ts. However, I never got around to doing it properly.

If you or anyone else is concerned about the scenario you described, more code would have to be added to address it safely.

@tyler-dane tyler-dane added the bug label Jul 2, 2024
@tyler-dane tyler-dane added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jul 21, 2024
@tyler-dane tyler-dane changed the title Channel id identification Make resource identification safer Jul 21, 2024
@tyler-dane tyler-dane moved this to Todo in v1 Cleanup Jul 21, 2024
@tyler-dane tyler-dane changed the title Make resource identification safer How to make resource identification safer Jul 21, 2024
@tyler-dane tyler-dane changed the title How to make resource identification safer How to make resource identification safer? Jul 22, 2024
@tyler-dane tyler-dane removed this from v1 Cleanup Oct 2, 2024
@tyler-dane tyler-dane removed the bug label Jan 18, 2025
@tyler-dane tyler-dane changed the title How to make resource identification safer? Not using unique identifier when receiving Gcal notification Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants