-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not using unique identifier when receiving Gcal notification #105
Comments
Hey @ondrejmoris, thanks for taking to time to document this. I think you're right about the resource id not being a sufficiently safe method to associate a calendar with a user. In fact, I think I went down the path of handling for this error with the If you or anyone else is concerned about the scenario you described, more code would have to be added to address it safely. |
Hi, i checked your codebase and i probably found an issue. I am not sure about that, so i'm gonna mark this as question.
When you receive notification from google (web_hook) you recognize a user and a calendar by resource id but i think you need to recognize by resource id and channel id.
What would happen if two users had connected same google calendars but with different event permissions? I think resourced id would be same. I think resource id is specific only for calendars not for google account and calendar.
The text was updated successfully, but these errors were encountered: