Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM creation sequence #738

Open
KrisThielemans opened this issue Jul 12, 2022 · 3 comments
Open

VM creation sequence #738

KrisThielemans opened this issue Jul 12, 2022 · 3 comments
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

We have an interesting circular thing going on now that the VM code is part of this repo. We need to tag the SIRF-SuperBuild before creating a VM, but we might need to fix things before tagging. The chain is

  1. A new VM is created via
    config.vm.provision "shell", path: "../scripts/bootstrap_ubuntu.sh"
  2. which calls UPDATE.sh (currently with the wrong branch)
    sudo -u $SIRFUSERNAME -H bash $userHOME/devel/SIRF-SuperBuild/VirtualBox/scripts/UPDATE.sh -t origin/vm_32
  3. and UPDATE.sh defaults to using the latest tag
    if [ $1 = 'default' ]
    then
    # get the latest tag matching v
    #SB_TAG=`git fetch; git for-each-ref refs/tags/v* --sort=-taggerdate --format='%(refname:short)' --count=1`
    SB_TAG=`git tag | xargs -I@ git log --format=format:"%at @%n" -1 @ | sort | awk '{print $2}' | tail -1`

It seems that we need to create it first with a locally modified Vagrantfile that sets -t origin/master, do all the tests, tag, and then recreate.

@paskino any better ideas?

PS: I do think that UPDATE.sh still needs to default to using the latest tag, as this is what update_VM.sh will use.

@KrisThielemans KrisThielemans added this to the v3.3 milestone Jul 12, 2022
@paskino
Copy link
Contributor

paskino commented Jul 14, 2022

I think this is what I generally do, anyway

@KrisThielemans KrisThielemans modified the milestones: v3.3, v3.4 Aug 25, 2022
@paskino paskino modified the milestones: v3.4, v3.5 Jan 19, 2023
@KrisThielemans KrisThielemans modified the milestones: v3.5, v3.6 Mar 16, 2023
@KrisThielemans
Copy link
Member Author

item 2 "wrong tag" is no longer relevant.

sudo -u $SIRFUSERNAME -H bash $userHOME/devel/SIRF-SuperBuild/VirtualBox/scripts/UPDATE.sh -s $*

@paskino
Copy link
Contributor

paskino commented Feb 29, 2024

We discussed that the SuperBuild code could be copied into the VM at creation time, similarly to how it is done in Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants