Skip to content

Commit 2e46fb6

Browse files
ryanbarlow97claude
andauthored
fix: reword player messages in character (#29)
Replace out-of-character wording in gameplay messages (permissions, containers, entities, chunks, plugin tags) with in-world phrasing. Staff commands, usage help and setup errors keep their plain wording. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent a439be0 commit 2e46fb6

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

‎src/main/java/net/tfminecraft/advancedcrafting/managers/CraftingManager.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,15 +220,15 @@ public void openStation(PlayerInteractEvent e) {
220220
StationFeedback f = station.addMaterial(p, i);
221221
switch (f) {
222222
case NOT_INGREDIENT:
223-
p.sendMessage("§cThis item cannot be used for crafting");
223+
p.sendMessage("§cThat is not a material you can work");
224224
p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f);
225225
break;
226226
case WRONG_TYPE:
227-
p.sendMessage("§cThis item type is not needed for the recipe");
227+
p.sendMessage("§cThis recipe does not call for that material");
228228
p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f);
229229
break;
230230
case CAPACITY:
231-
p.sendMessage("§cYou already have the needed amount of this type");
231+
p.sendMessage("§cThe piece already has enough of that material");
232232
p.playSound(p.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 1f, 0.5f);
233233
break;
234234
case NO_PERMS:
@@ -354,7 +354,7 @@ public void applyHit(PlayerInteractEvent e) {
354354
p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f);
355355
break;
356356
case WRONG_TYPE:
357-
p.sendMessage("§cThis item cannot be used for crafting hits");
357+
p.sendMessage("§cYou cannot work the piece with that tool");
358358
p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f);
359359
break;
360360
case NONE:

‎src/main/java/net/tfminecraft/advancedcrafting/utils/ProfessionPermissions.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,14 @@ public static int resolveAlloyTier(String alloyId) {
123123
}
124124

125125
public static String missingIngredientPermissionMessage(String permissionKey) {
126-
return "§cYou need the " + getDisplayName(permissionKey) + " permission to use this material.";
126+
return "§cYou are not skilled enough in " + getDisplayName(permissionKey) + " to work this material.";
127127
}
128128

129129
public static String missingNamespaceMessage(String namespace) {
130-
return "§cYou need at least one of the " + getDisplayName(namespace) + " permissions.";
130+
return "§cYou are not skilled enough in " + getDisplayName(namespace) + " to make this.";
131131
}
132132

133133
public static String missingExactTierMessage(String namespace, int tier) {
134-
return "§cYou need the " + getDisplayName(namespace) + " tier " + tier + " permission to use this material.";
134+
return "§cYour " + getDisplayName(namespace) + " training does not extend to tier " + tier + " materials.";
135135
}
136136
}

‎src/main/resources/config.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,11 @@ permission-namespaces:
8383
ingredient:
8484
display: "#e6a817Ingredient"
8585
iron_smith:
86-
display: "#e6a817Iron_Smith"
86+
display: "#e6a817Iron Smithing"
8787
steel_smith:
88-
display: "#e6a817Steel_Smith"
88+
display: "#e6a817Steel Smithing"
8989
abyssalite_smith:
90-
display: "#e6a817Abyssalite_Smith"
90+
display: "#e6a817Abyssalite Smithing"
9191
mythril_smith:
92-
display: "#e6a817Mythril_Smith"
92+
display: "#e6a817Mythril Smithing"
9393

‎src/test/java/net/tfminecraft/advancedcrafting/AlloyManagerCoverageTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ void interactionValidatesStructureMaterialPermissionsCapacityAndCooldown() throw
8383
assertFalse(m.hasStation(b.getLocation()));
8484
clearCooldown(m);
8585
m.addIngredient(event(p, b));
86-
assertTrue(p.nextMessage().contains("permission"));
86+
assertTrue(p.nextMessage().contains("not skilled enough"));
8787
p.setOp(true);
8888
clearCooldown(m);
8989
p.getInventory().setItemInMainHand(base.build());

0 commit comments

Comments
 (0)