Address review: drop a stale scheme tag and malformed recorded inputs

- applyTo removes ac_craft_model_scheme when the recipe or inputs no longer
  resolve, so ArmourShop never trusts an old metal.
- readFrom drops recorded inputs with a null entry, kind or id, which every
  refresh consumer (outdated check, stat calculator, majority tier, scheme
  resolver) reads; the resolver also skips them when called directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: XxFran10xX

src/main/java/net/tfminecraft/advancedcrafting/objects/data/CraftProvenance.java

@@ -107,6 +107,9 @@ public void applyTo(ItemStack item) {
 		if (scheme != null) {
 			meta.getPersistentDataContainer().set(PDCKeys.craftModelScheme(), PersistentDataType.STRING,
 					scheme.getId());
+		} else {
+			// A recipe or ingredient that no longer resolves must not leave an old metal for ArmourShop to trust.
+			meta.getPersistentDataContainer().remove(PDCKeys.craftModelScheme());
 		}
 		item.setItemMeta(meta);
 	}
@@ -129,7 +132,12 @@ public static CraftProvenance readFrom(ItemStack item) {
 		if (inputsJson != null) {
 			List<CraftInput> parsed = GSON.fromJson(inputsJson, new TypeToken<List<CraftInput>>() {}.getType());
 			if (parsed != null) {
-				inputs = parsed;
+				// Every refresh consumer reads these inputs; a hand-edited or truncated record must not break them.
+				for (CraftInput input : parsed) {
+					if (input != null && input.getKind() != null && input.getId() != null) {
+						inputs.add(input);
+					}
+				}
 			}
 		}
 		Integer templateRevision = meta.getPersistentDataContainer().get(PDCKeys.craftStatTemplateRevision(),

src/main/java/net/tfminecraft/advancedcrafting/utils/ModelSchemeResolver.java

@@ -28,6 +28,9 @@ public static ModelScheme resolve(CraftingRecipe recipe, List<CraftInput> inputs
 		}
 		HashMap<String, Integer> materials = new HashMap<>();
 		for (CraftInput input : inputs) {
+			if (input == null || input.getKind() == null || input.getId() == null) {
+				continue;
+			}
 			materials.put(input.getKind().toLowerCase() + "." + input.getId().toLowerCase(), input.getAmount());
 		}
 		ModelScheme main = schemeOf(MajorityTierResolver.resolveMajorityKey(recipe, materials), null, null);

src/test/java/net/tfminecraft/advancedcrafting/ItemMetadataCoverageTest.java

@@ -223,6 +223,25 @@ void craftProvenanceRoundTripsAndDetectsIngredientAndTemplateRevisions() throws
     meta.getPersistentDataContainer().set(PDCKeys.craftInputs(), PersistentDataType.STRING, "null");
     minimal.setItemMeta(meta);
     assertTrue(CraftProvenance.readFrom(minimal).getInputs().isEmpty());
+    // Malformed records (null entries, kinds or ids) are dropped instead of breaking every refresh.
+    meta = minimal.getItemMeta();
+    meta.getPersistentDataContainer()
+        .set(
+            PDCKeys.craftInputs(),
+            PersistentDataType.STRING,
+            "[null,{\"id\":\"iron\",\"n\":1},{\"k\":\"ingredient\",\"n\":1},"
+                + "{\"k\":\"ingredient\",\"id\":\"iron\",\"n\":2,\"r\":1}]");
+    minimal.setItemMeta(meta);
+    var kept = CraftProvenance.readFrom(minimal).getInputs();
+    assertEquals(1, kept.size());
+    assertEquals("iron", kept.get(0).getId());
+    // A record whose recipe no longer resolves loses its old scheme tag.
+    meta = minimal.getItemMeta();
+    meta.getPersistentDataContainer().set(PDCKeys.craftModelScheme(), PersistentDataType.STRING, "old");
+    minimal.setItemMeta(meta);
+    CraftProvenance.readFrom(minimal).applyTo(minimal);
+    assertNull(
+        minimal.getItemMeta().getPersistentDataContainer().get(PDCKeys.craftModelScheme(), PersistentDataType.STRING));
     assertNotNull(new CraftProvenance().getInputs());
   }
 

src/test/java/net/tfminecraft/advancedcrafting/ModelSchemeResolverTest.java

@@ -67,6 +67,13 @@ void recordedCraftsResolveTheSchemeTheirLookCameFromAndAlloysUseTheirBase() thro
             in("ingredient", "", 1),
             in("misc", "x", 1)));
     assertNull(scheme(noModel, in("ingredient", "gone", 1)));
+    // Malformed inputs are skipped.
+    assertEquals(
+        "iron",
+        ModelSchemeResolver.resolve(
+                noModel,
+                Arrays.asList(null, in(null, "iron", 1), in("ingredient", null, 1), in("ingredient", "iron", 3)))
+            .getId());
     assertNull(scheme(noModel, in("alloy", "gone", 1)));
   }
 }