Keep a join sweep going past a broken item and ignore malformed model paths

A recorded craft whose MMOItems data is gone threw in the stat refresh and
stopped the whole join sweep on TFMCDev01, so the rest of that inventory was
not refreshed or migrated. CraftRefreshListener now logs the item and
carries on. A v.<material>.<model> path with a non-numeric model no longer
throws in the look migration; it simply does not match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: XxFran10xX

src/main/java/net/tfminecraft/advancedcrafting/managers/CraftRefreshListener.java

@@ -126,7 +126,14 @@ private void tryRefresh(ItemStack item, ItemConsumer writer) {
 		if (item == null || item.getType().isAir() || !AcItemRefresher.isManaged(item)) {
 			return;
 		}
-		ItemStack refreshed = AcItemRefresher.refreshIfOutdated(item);
+		ItemStack refreshed;
+		try {
+			refreshed = AcItemRefresher.refreshIfOutdated(item);
+		} catch (RuntimeException e) {
+			// One broken item (e.g. a recorded craft whose MMOItems data is gone) must not stop the rest of a sweep.
+			AdvancedCrafting.plugin.getLogger().warning("Could not refresh " + item.getType() + ": " + e);
+			return;
+		}
 		if (refreshed == item) {
 			return;
 		}

src/main/java/net/tfminecraft/advancedcrafting/utils/ArmourLookMigrator.java

@@ -97,7 +97,12 @@ static boolean wears(ItemStack item, String path) {
 				|| !item.getType().name().equalsIgnoreCase(parts[1])) {
 			return false;
 		}
-		int model = Integer.parseInt(parts[2]);
+		int model;
+		try {
+			model = Integer.parseInt(parts[2]);
+		} catch (NumberFormatException e) {
+			return false;
+		}
 		ItemMeta meta = item.getItemMeta();
 		int current = LegacyModelData.has(meta) ? LegacyModelData.get(meta) : 0;
 		return current == model;

src/test/java/net/tfminecraft/advancedcrafting/ArmourLookMigratorTest.java

@@ -305,6 +305,7 @@ void looksAreMatchedAndDescribedByTheirSchemePath() throws Exception {
 
     assertTrue((boolean) wears.invoke(null, plain, "v.chainmail_helmet.0"));
     assertFalse((boolean) wears.invoke(null, plain, "v.chainmail_helmet"));
+    assertFalse((boolean) wears.invoke(null, plain, "v.chainmail_helmet.x"), "a malformed model never matches");
     assertFalse((boolean) wears.invoke(null, plain, "m.helmets.light_custom_helmet"));
     assertFalse((boolean) wears.invoke(null, plain, "ia.tfmc_armor:iron_light_helmet"));
     assertEquals("v.chainmail_helmet.0", describe.invoke(null, plain));

src/test/java/net/tfminecraft/advancedcrafting/RefreshListenerCoverageTest.java

@@ -158,6 +158,32 @@ void joinSweepRefreshesInventoryArmourOffhandAndEnderChestOneTickLater() throws
     verify(gone, never()).getInventory();
   }
 
+  @Test
+  void aBrokenItemIsLoggedAndTheSweepCarriesOn() {
+    when(plugin.isEnabled()).thenReturn(true);
+    var p = server.addPlayer();
+    var broken = new ItemStack(Material.IRON_HELMET);
+    var next = new ItemStack(Material.IRON_BOOTS);
+    var refreshed = new ItemStack(Material.LEATHER_BOOTS);
+    p.getInventory().setItem(0, broken);
+    p.getInventory().setItem(1, next);
+    try (var refresher = mockStatic(AcItemRefresher.class)) {
+      refresher.when(() -> AcItemRefresher.isManaged(any())).thenReturn(true);
+      refresher
+          .when(() -> AcItemRefresher.refreshIfOutdated(argThat(i -> i != null && i.getType() == Material.IRON_HELMET)))
+          .thenThrow(new NullPointerException("no MMOItems type"));
+      refresher
+          .when(() -> AcItemRefresher.refreshIfOutdated(argThat(i -> i != null && i.getType() == Material.IRON_BOOTS)))
+          .thenReturn(refreshed);
+      var join = mock(PlayerJoinEvent.class);
+      when(join.getPlayer()).thenReturn(p);
+      new CraftRefreshListener().onJoin(join);
+      server.getScheduler().performOneTick();
+    }
+    assertEquals(Material.IRON_HELMET, p.getInventory().getItem(0).getType());
+    assertEquals(Material.LEATHER_BOOTS, p.getInventory().getItem(1).getType());
+  }
+
   @Test
   void openSweepOnlyTouchesWorldStorageAfterTheEvent() throws Exception {
     when(plugin.isEnabled()).thenReturn(true);