Autoresolve campaign battles by simulation (#56)

Autoresolve no longer starts a live battle. Each side's committed
regiments become lives, a luck roll scales them, and Lanchester's
square law picks the winner and the winner's losses. The loser loses a
set share of its lives. Losses go through the normal casualty and
outcome path, with the offensive pinned so fuel is charged correctly.

A stalled battle vote postpones once (war.battle_voting.max_postponements)
and then autoresolves. Legacy AUTORESOLVE_PENDING wars are resolved on
the next tick. Battle start hours are now 21 to 23; the window end hour
is not a start time.

Co-authored-by: Ryan <7389646+ryanbarlow97@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: 3 people

src/main/java/net/tfminecraft/simplefactions/Cache.java

@@ -106,6 +106,9 @@ public static boolean requireProvinces(org.bukkit.command.CommandSender sender)
 	public static boolean warBattleVotingPassIfEither;
 	public static int warBattleVotingDevMinPlayers;
 	public static boolean warBattleVotingDevMinPlayersEnabled;
+	public static int warBattleVotingMaxPostponements = 1;
+	public static double warAutoresolveLuck = 0.15;
+	public static double warAutoresolveLoserLossFraction = 0.5;
 	public static int warBattleLivesPerRegiment;
 	public static int warBattleMinSideLives;
 	public static int warBattleDeathsPerRegimentLoss;

src/main/java/net/tfminecraft/simplefactions/loaders/ConfigLoader.java

@@ -213,6 +213,18 @@ public void loadWar(File warFile) {
 		} else {
 			Cache.warBattleVotingDevMinPlayers = Cache.warBattleVotingMinPlayers;
 		}
+		Cache.warBattleVotingMaxPostponements = Math.max(
+				0,
+				config.getInt("war.battle_voting.max_postponements", 1));
+		double autoresolveLuck = config.getDouble("war.autoresolve.luck", 0.15);
+		if (autoresolveLuck < 0) {
+			autoresolveLuck = 0;
+		} else if (autoresolveLuck > 1) {
+			autoresolveLuck = 1;
+		}
+		Cache.warAutoresolveLuck = autoresolveLuck;
+		double loserLossFraction = config.getDouble("war.autoresolve.loser_loss_fraction", 0.5);
+		Cache.warAutoresolveLoserLossFraction = loserLossFraction < 0 ? 0 : loserLossFraction;
 		Cache.warDevmodePhantomCount = config.getInt("war.devmode.phantom_count", 10);
 		validateBattleScheduleConfig();
 

src/main/java/net/tfminecraft/simplefactions/war/battle/campaign/CampaignBattleLaunchService.java

@@ -25,6 +25,7 @@
 import net.tfminecraft.simplefactions.war.campaign.progression.AttackerNavalContestService;
 import net.tfminecraft.simplefactions.war.campaign.progression.CampaignCapabilityService;
 import net.tfminecraft.simplefactions.war.campaign.progression.postbattle.CampaignOffensiveForfeitService;
+import net.tfminecraft.simplefactions.war.campaign.runtime.BattleAutoresolveService;
 import net.tfminecraft.simplefactions.war.campaign.runtime.BattleScheduleService;
 import net.tfminecraft.simplefactions.war.campaign.runtime.BattleSideMembers;
 import net.tfminecraft.simplefactions.war.campaign.runtime.BattleWindowService;
@@ -69,37 +70,13 @@ public static Battle prepareScheduledBattle(War war) {
 		return battle;
 	}
 
+	/** Simulated result. Does not create or start a live battle. */
 	public static Battle launchAutoresolveBattle(War war) {
 		if (war == null || !war.isActive()) {
 			return null;
 		}
-		Battle existing = BattleManager.getByWarId(war.getId());
-		Integer provinceId = BattleScheduleService.resolveScheduledProvinceId(war);
-		if (provinceId != null
-				&& AttackerNavalContestService.applyIfAttackerHasNoBerthedNavy(war, provinceId)) {
-			return null;
-		}
-
-		if (existing != null) {
-			String startError = startPreparedBattle(war, existing);
-			if (startError != null) {
-				logWarning("Could not start autoresolve battle: " + startError);
-			}
-			return existing;
-		}
-
-		if (provinceId == null) {
-			return null;
-		}
-
-		Battle battle = createCampaignBattle(war, provinceId, true);
-		if (battle != null) {
-			String startError = startPreparedBattle(war, battle);
-			if (startError != null) {
-				logWarning("Could not start autoresolve battle: " + startError);
-			}
-		}
-		return battle;
+		BattleAutoresolveService.resolve(war);
+		return null;
 	}
 
 	public static boolean tryStartScheduledBattle(War war, Instant now) {

src/main/java/net/tfminecraft/simplefactions/war/battle/campaign/CampaignBattleOutcomeService.java

@@ -126,6 +126,8 @@ public static CampaignBattleApplyResult applyCampaignBattleOutcome(
 			return new CampaignBattleApplyResult(false, false, Optional.empty());
 		}
 
+		war.setPostponementsThisCycle(0);
+
 		CampaignPushTarget preBattlePushTarget = war.getPushTarget();
 		ObjectiveHolder preBattleObjectiveHeldBy = war.getObjectiveHeldBy();
 

src/main/java/net/tfminecraft/simplefactions/war/campaign/admin/WarScheduleAdminService.java

@@ -147,6 +147,8 @@ public static WarScheduleAdminResult closeVote(War war, Instant now) {
 
 			case AUTORESOLVE_PENDING -> WarScheduleAdminResult.ok("Vote close set AUTORESOLVE_PENDING.");
 
+			case AUTORESOLVED -> WarScheduleAdminResult.ok("Vote close autoresolved the battle.");
+
 			case BLOCKED_DEFENDER_CHOICE -> WarScheduleAdminResult.error(
 
 					"Vote close blocked: defender choice unresolved.");

src/main/java/net/tfminecraft/simplefactions/war/campaign/admin/WarScheduleFeedbackFormatter.java

@@ -64,6 +64,10 @@ private static String formatCloseVote(War war) {
 			return "§7Phase: §e" + formatPhase(war);
 		}
 		if (phase == BattleSchedulePhase.VOTING && war.getScheduledBattleAt() == null) {
+			if (war.getPostponementsThisCycle() == 0) {
+				return "§7Autoresolved §7· Battle day: §e" + formatBattleDay(war)
+						+ " §7· Phase: §e" + formatPhase(war);
+			}
 			return "§7Postponed §7· Battle day: §e" + formatBattleDay(war)
 					+ " §7· Phase: §e" + formatPhase(war);
 		}