Merge pull request #49 from tipoff/chx2/feature/46-email-address

Update Email address relationship #46

Author: drewroberts

database/factories/ContactFactory.php

@@ -15,14 +15,14 @@ class ContactFactory extends Factory
     public function definition()
     {
         return [
-            'form_type'      => $this->faker->randomElement(FormType::getValues()),
-            'location_id'    => randomOrCreate(app('location')),
-            'email'          => $this->faker->email,
-            'first_name'     => $this->faker->firstName,
-            'last_name'      => $this->faker->lastName,
-            'phone'          => '555-555-5555',
-            'company_name'   => $this->faker->company,
-            'message'        => $this->faker->paragraph,
+            'form_type'         => $this->faker->randomElement(FormType::getValues()),
+            'location_id'       => randomOrCreate(app('location')),
+            'email_address_id'  => randomOrCreate(app('email_address')),
+            'first_name'        => $this->faker->firstName,
+            'last_name'         => $this->faker->lastName,
+            'phone'             => '555-555-5555',
+            'company_name'      => $this->faker->company,
+            'message'           => $this->faker->paragraph,
         ];
     }
 }

database/migrations/2020_05_20_100000_create_contacts_table.php

@@ -15,7 +15,7 @@ public function up()
             $table->string('form_type')->index();
             $table->string('reference_number')->index()->unique(); // Generated by system. This is identifier used to communicate with customer about their contact form. Reference number is emailed to them.
             $table->foreignIdFor(app('location'))->index();
-            $table->string('email');
+            $table->foreignIdFor(app('email_address'))->index();
             $table->foreignIdFor(app('user'))->nullable()->index();
             $table->string('first_name')->nullable();
             $table->string('last_name')->nullable();

src/Commands/AttachContactUsers.php

@@ -4,7 +4,6 @@
 
 namespace Tipoff\Forms;
 
-use Tipoff\Forms\Commands\AttachContactUsers;
 use Tipoff\Forms\Models\Contact;
 use Tipoff\Forms\Models\ContactResponse;
 use Tipoff\Forms\Policies\ContactPolicy;
@@ -25,9 +24,6 @@ public function configureTipoffPackage(TipoffPackage $package): void
                 \Tipoff\Forms\Nova\Contact::class,
                 \Tipoff\Forms\Nova\ContactResponse::class,
             ])
-            ->hasCommands([
-                AttachContactUsers::class,
-            ])
             ->name('forms')
             ->hasConfigFile();
     }

src/FormsServiceProvider.php

@@ -77,6 +77,11 @@ public function getContactStatusHistory(): Collection
         return $this->getStatusHistory(ContactStatus::statusType());
     }
 
+    public function email()
+    {
+        return $this->hasOne(app('email_address'));
+    }
+
     public function response()
     {
         return $this->hasOne(ContactResponse::class);

src/Models/Contact.php

@@ -6,7 +6,6 @@
 
 use Dniccum\PhoneNumber\PhoneNumber;
 use Illuminate\Http\Request;
-use Inspheric\Fields\Email;
 use Laravel\Nova\Fields\BelongsTo;
 use Laravel\Nova\Fields\Date;
 use Laravel\Nova\Fields\DateTime;
@@ -71,7 +70,7 @@ public function fields(Request $request)
             nova('location') ? BelongsTo::make('Location', 'location', nova('location'))->required()->hideWhenUpdating() : null,
             nova('user') ? BelongsTo::make('User', 'user', nova('user'))->required()->hideWhenUpdating() : null,
             PhoneNumber::make('Phone')->format('###-###-####')->disableValidation()->useMaskPlaceholder()->linkOnDetail()->hideWhenUpdating(),
-            Email::make('Email', 'user.email')->clickable()->hideWhenUpdating(),
+            nova('email_address') ? BelongsTo::make('Email Address', 'email_address', nova('email_address'))->sortable() : null,
             Textarea::make('Message')->rows(3)->alwaysShow()->nullable()->hideWhenUpdating(),
 
             new Panel('Submission Details', $this->submissionFields()),