Use Enum for Form Type #30

Author: chx2

database/factories/ContactFactory.php

@@ -1,10 +1,11 @@
-<?php 
+<?php
 
 declare(strict_types=1);
 
 namespace Tipoff\Forms\Database\Factories;
 
 use Illuminate\Database\Eloquent\Factories\Factory;
+use Tipoff\Forms\Enums\FormType;
 use Tipoff\Forms\Models\Contact;
 
 class ContactFactory extends Factory
@@ -14,7 +15,7 @@ class ContactFactory extends Factory
     public function definition()
     {
         return [
-            'form_type'      => $this->faker->randomElement(['contact', 'reservation', 'parties', 'groups', 'employment']),
+            'form_type'      => $this->faker->randomElement(FormType::getValues()),
             'location_id'    => randomOrCreate(app('location')),
             'email'          => $this->faker->email,
             'first_name'     => $this->faker->firstName,

database/migrations/2020_05_20_100000_create_contacts_table.php

@@ -12,7 +12,7 @@ public function up()
     {
         Schema::create('contacts', function (Blueprint $table) {
             $table->id();
-            $table->string('form_type')->index(); // Todo: Change this to enum?
+            $table->string('form_type')->index();
             $table->string('reference_number')->index()->unique(); // Generated by system. This is identifier used to communicate with customer about their contact form. Reference number is emailed to them.
             $table->foreignIdFor(app('location'))->index();
             $table->string('email');

src/Enums/FormType.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tipoff\Forms\Enums;
+
+use MabeEnum\Enum;
+
+/**
+ * @method static FormType CONTACT()
+ * @method static FormType EMPLOYMENT()
+ * @method static FormType GROUPS()
+ * @method static FormType PARTIES()
+ * @method static FormType RESERVATIONS()
+ * @psalm-immutable
+ */
+class FormType extends Enum
+{
+    const CONTACT = 'contact';
+    const EMPLOYMENT = 'employment';
+    const GROUPS = 'groups';
+    const PARTIES = 'parties';
+    const RESERVATIONS = 'reservations';
+}

src/Nova/Contact.php

@@ -18,6 +18,7 @@
 use Laravel\Nova\Http\Requests\NovaRequest;
 use Laravel\Nova\Panel;
 use Tipoff\Forms\Enums\ContactStatus;
+use Tipoff\Forms\Enums\FormType;
 use Tipoff\Support\Nova\BaseResource;
 use Tipoff\Support\Nova\Fields\Enum;
 
@@ -61,11 +62,11 @@ public function fields(Request $request)
                 return $contact->getContactStatus();
             })->attach(ContactStatus::class),
             Select::make('Form Type')->options([
-                'contact' => 'Contact Page',
-                'reservation' => 'Reservation Page',
-                'parties' => 'Private Parties Page',
-                'groups' => 'Team Building Page',
-                'employment' => 'Employment Page',
+                FormType::CONTACT => 'Contact',
+                FormType::RESERVATIONS => 'Reservations',
+                FormType::PARTIES => 'Parties',
+                FormType::GROUPS => 'Groups',
+                FormType::EMPLOYMENT => 'Employment',
             ])->required()->hideWhenUpdating(),
             nova('location') ? BelongsTo::make('Location', 'location', nova('location'))->required()->hideWhenUpdating() : null,
             nova('user') ? BelongsTo::make('User', 'user', nova('user'))->required()->hideWhenUpdating() : null,