-
Notifications
You must be signed in to change notification settings - Fork 55
Enh/live admin view #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/live admin view #1564
Conversation
…adable-in-dark-mode' into enh/live-admin-view
carlobortolan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and it worked when accessing the URL directly (e.g., http://localhost:8081/admin/management/52/98), but I couldn’t find a way to navigate to the new admin view via the UI; am I missing something? 😅
web/admin.go
Outdated
|
|
||
| if c.Query("restart") == "1" { | ||
| c.Redirect(http.StatusFound, strings.Split(c.Request.RequestURI, "?")[0]) | ||
| // TODO: Add restart functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be a placeholder? 😅
(If it’s not implemented yet, I’d suggest leaving it out for now to avoid any confusion.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this and it seems like we do not have a restart functionality at all (also the restart button on the watch page does not do anything apart from reloading the webpage). I'll create a new issue to implement a real restart functionality that checks the stream and if needed restarts the stream on the runner
Actually I forgot to add this functionality in this PR but it is added in #1565 |
Motivation and Context
This pull request adds a new admin panel to use during livestreams. This panel allows presenters to see the live stream with some information on it. There are also buttons to start and stop the stream and a live chat view.
More features will be added in the future to this panel (e.g. reactions from students).
Screenshots