Skip to content

Conversation

@SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Apr 17, 2025

Motivation and Context

This pull request adds a new admin panel to use during livestreams. This panel allows presenters to see the live stream with some information on it. There are also buttons to start and stop the stream and a live chat view.

More features will be added in the future to this panel (e.g. reactions from students).

Screenshots

image

@SebiWrn SebiWrn requested a review from a team April 17, 2025 14:11
@SebiWrn SebiWrn self-assigned this Apr 17, 2025
@SebiWrn SebiWrn linked an issue Apr 17, 2025 that may be closed by this pull request
@SebiWrn SebiWrn mentioned this pull request Apr 17, 2025
Copy link
Member

@carlobortolan carlobortolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it worked when accessing the URL directly (e.g., http://localhost:8081/admin/management/52/98), but I couldn’t find a way to navigate to the new admin view via the UI; am I missing something? 😅

web/admin.go Outdated

if c.Query("restart") == "1" {
c.Redirect(http.StatusFound, strings.Split(c.Request.RequestURI, "?")[0])
// TODO: Add restart functionality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be a placeholder? 😅
(If it’s not implemented yet, I’d suggest leaving it out for now to avoid any confusion.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this and it seems like we do not have a restart functionality at all (also the restart button on the watch page does not do anything apart from reloading the webpage). I'll create a new issue to implement a real restart functionality that checks the stream and if needed restarts the stream on the runner

@SebiWrn
Copy link
Collaborator Author

SebiWrn commented Jun 18, 2025

I tested it locally and it worked when accessing the URL directly (e.g., http://localhost:8081/admin/management/52/98), but I couldn’t find a way to navigate to the new admin view via the UI; am I missing something? 😅

Actually I forgot to add this functionality in this PR but it is added in #1565

@SebiWrn SebiWrn requested a review from carlobortolan June 18, 2025 11:27
@SebiWrn SebiWrn merged commit 35dbd1d into dev Jul 22, 2025
10 checks passed
@SebiWrn SebiWrn deleted the enh/live-admin-view branch July 22, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live reactions for lectures

3 participants