Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCode] Should show inline diff when Tabby suggest changes #3422

Closed
zwpaper opened this issue Nov 14, 2024 · 4 comments
Closed

[VSCode] Should show inline diff when Tabby suggest changes #3422

zwpaper opened this issue Nov 14, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zwpaper
Copy link
Member

zwpaper commented Nov 14, 2024

Please describe the feature you want

Currently, Tabby suggests changes through diff lines, like:

CleanShot 2024-11-14 at 14 29 19@2x

It would be great if we could display the inline diff, highlighting the background of the uppercase characters:

image

Additional context
Add any other context or screenshots about the feature request here.


Please reply with a 👍 if you want this feature.

@zwpaper zwpaper added the enhancement New feature or request label Nov 14, 2024
@wsxiaoys wsxiaoys added the good first issue Good for newcomers label Nov 14, 2024
@juangcarmona
Copy link

Hi there!

I am not sure if anyone is working on this. I took me some time to figure out where to start, but it was a nice exercise... I created a branch and I worked on something that, well, "solved" the issue, but only the happy path. I need to implement a mechanism that considers the original code as well as the diff panel content and the added, removed and lines kept equal as shown at the end of that diff panel (i.e.: [+=--==++], or, as in the example, [-----+++++])

I am working on this branch: https://github.com/juangcarmona/tabby/tree/feature/inline-diff-highlight

@wsxiaoys
Copy link
Member

#3709 is currently in progress and is expected to be merged soon. Thank you for your exploratory work! I recommend checking out other issues that might interest you.

@juangcarmona
Copy link

Oh! As I didn't see an assignee...

Just for the shake of my curiosity, I'll try to see @wsxiaoys PR during the morning to understand that approach. Cheers!

@wsxiaoys
Copy link
Member

Fixed in #3709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants