Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavefront values.yaml file collecting tech debt #76

Open
doddatpivotal opened this issue Jul 21, 2020 · 0 comments
Open

Wavefront values.yaml file collecting tech debt #76

doddatpivotal opened this issue Jul 21, 2020 · 0 comments

Comments

@doddatpivotal
Copy link
Collaborator

The wavefront values file wf.yaml has set values beyond what is intentionally overriden, thus causing debt from default. The most explicit scenario are the container versions.

Instead, the values file should only contain that which is explicity set.

From what I can tell, that only includes the following:

  • kubeStateMetrics.enabled=true
  • proxy.ports(alltypes)

collector.discovery.config is defined twice, which questions whether it works or not. Recommend removing the second key and leaving this as an example of how to do discovery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant