Skip to content

Commit d5e4925

Browse files
committed
In JavaScriptEngineSwitcher.Jint added support of Jint version 3.0.0 Beta 1914
1 parent b409ba8 commit d5e4925

File tree

6 files changed

+13
-54
lines changed

6 files changed

+13
-54
lines changed

src/JavaScriptEngineSwitcher.Jint/CustomCancellationConstraint.cs

Lines changed: 0 additions & 34 deletions
This file was deleted.

src/JavaScriptEngineSwitcher.Jint/JavaScriptEngineSwitcher.Jint.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
<NoWarn>$(NoWarn);CS1591;NU5104</NoWarn>
1111
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1212
<DisableDefaultResxToCsConversionTarget>true</DisableDefaultResxToCsConversionTarget>
13-
<Description>JavaScriptEngineSwitcher.Jint contains adapter `JintJsEngine` (wrapper for the Jint JavaScript Engine (http://github.com/sebastienros/jint) version 3.0.0 Beta 1828).</Description>
13+
<Description>JavaScriptEngineSwitcher.Jint contains adapter `JintJsEngine` (wrapper for the Jint JavaScript Engine (http://github.com/sebastienros/jint) version 3.0.0 Beta 1914).</Description>
1414
<PackageIcon>icon.png</PackageIcon>
1515
<PackageTags>JavaScriptEngineSwitcher;JavaScript;ECMAScript;Jint</PackageTags>
16-
<PackageReleaseNotes>Added a ability to interrupt execution of the script.</PackageReleaseNotes>
16+
<PackageReleaseNotes>Jint was updated to version 3.0.0 Beta 1914.</PackageReleaseNotes>
1717
</PropertyGroup>
1818

1919
<Import Project="../../build/common.props" />
@@ -23,7 +23,7 @@
2323

2424
<ItemGroup>
2525
<PackageReference Include="AdvancedStringBuilder" Version="0.1.0" />
26-
<PackageReference Include="Jint" Version="3.0.0-beta-1828" />
26+
<PackageReference Include="Jint" Version="3.0.0-beta-1914" />
2727

2828
<ProjectReference Include="../JavaScriptEngineSwitcher.Core/JavaScriptEngineSwitcher.Core.csproj" />
2929
</ItemGroup>

src/JavaScriptEngineSwitcher.Jint/JintJsEngine.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44

55
using Jint;
66
using IOriginalPrimitiveInstance = Jint.Native.IPrimitiveInstance;
7+
using OriginalCancellationConstraint = Jint.Constraints.CancellationConstraint;
78
using OriginalEngine = Jint.Engine;
9+
using OriginalExecutionCanceledException = Jint.Runtime.ExecutionCanceledException;
810
using OriginalJavaScriptException = Jint.Runtime.JavaScriptException;
911
using OriginalMemoryLimitExceededException = Jint.Runtime.MemoryLimitExceededException;
1012
using OriginalObjectInstance = Jint.Native.Object.ObjectInstance;
@@ -63,7 +65,7 @@ public sealed class JintJsEngine : JsEngineBase
6365
/// <summary>
6466
/// Constraint for canceling of script execution
6567
/// </summary>
66-
private CustomCancellationConstraint _cancellationConstraint;
68+
private OriginalCancellationConstraint _cancellationConstraint;
6769

6870
/// <summary>
6971
/// Synchronizer of code execution
@@ -91,7 +93,7 @@ public JintJsEngine()
9193
public JintJsEngine(JintSettings settings)
9294
{
9395
_cancellationTokenSource = new CancellationTokenSource();
94-
_cancellationConstraint = new CustomCancellationConstraint(_cancellationTokenSource.Token);
96+
_cancellationConstraint = new OriginalCancellationConstraint(_cancellationTokenSource.Token);
9597

9698
JintSettings jintSettings = settings ?? new JintSettings();
9799

@@ -100,6 +102,7 @@ public JintJsEngine(JintSettings settings)
100102
_jsEngine = new OriginalEngine(options => {
101103
options
102104
.AllowDebuggerStatement(jintSettings.AllowDebuggerStatement)
105+
.WithoutConstraint(c => c is OriginalCancellationConstraint)
103106
.Constraint(_cancellationConstraint)
104107
.DebugMode(jintSettings.EnableDebugging)
105108
.LimitMemory(jintSettings.MemoryLimit)
@@ -301,7 +304,7 @@ private WrapperRuntimeException WrapRuntimeException(OriginalRuntimeException or
301304
wrapperRuntimeException = new WrapperRuntimeException(message, EngineName, EngineVersion,
302305
originalRuntimeException);
303306
}
304-
else if (originalRuntimeException is ScriptExecutionCanceledException)
307+
else if (originalRuntimeException is OriginalExecutionCanceledException)
305308
{
306309
_cancellationTokenSource = new CancellationTokenSource();
307310
_cancellationConstraint.Reset(_cancellationTokenSource.Token);

src/JavaScriptEngineSwitcher.Jint/ScriptExecutionCanceledException.cs

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/JavaScriptEngineSwitcher.Jint/readme.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,13 @@
1212
DESCRIPTION
1313
===========
1414
JavaScriptEngineSwitcher.Jint contains adapter `JintJsEngine` (wrapper for the
15-
Jint JavaScript Engine (http://github.com/sebastienros/jint) version 3.0.0 Beta 1828).
15+
Jint JavaScript Engine (http://github.com/sebastienros/jint) version
16+
3.0.0 Beta 1914).
1617

1718
=============
1819
RELEASE NOTES
1920
=============
20-
Added a ability to interrupt execution of the script.
21+
Jint was updated to version 3.0.0 Beta 1914.
2122

2223
=============
2324
DOCUMENTATION

test/JavaScriptEngineSwitcher.Tests/Jint/PrecompilationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public void MappingRuntimeErrorDuringExecutionOfPrecompiledCodeIsCorrect()
101101
// Assert
102102
Assert.NotNull(exception);
103103
Assert.Equal("Runtime error", exception.Category);
104-
Assert.Equal("items is null", exception.Description);
104+
Assert.Equal("Cannot read property 'items' of null", exception.Description);
105105
Assert.Equal("TypeError", exception.Type);
106106
Assert.Equal("get-item.js", exception.DocumentName);
107107
Assert.Equal(2, exception.LineNumber);

0 commit comments

Comments
 (0)