Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the title for external video players #43

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Set the title for external video players #43

merged 1 commit into from
Sep 25, 2015

Conversation

epitron
Copy link
Contributor

@epitron epitron commented Sep 24, 2015

This makes the external player experience nicer.

I had to set the title twice on the intent, since "Intent.EXTRA_TITLE" didn't work on MX Player. (MX Player's supported intent data is here: https://sites.google.com/site/mxvpen/api).

I think I did that correctly. Anyhow, it works. :)

@epitron epitron mentioned this pull request Sep 24, 2015
@theScrabi
Copy link
Member

Ok I see if i can also apply that to audio streaming. :) Thanks for the help.

theScrabi added a commit that referenced this pull request Sep 25, 2015
Set the title for external video players
@theScrabi theScrabi merged commit d8bdada into TeamNewPipe:master Sep 25, 2015
@epitron
Copy link
Contributor Author

epitron commented Sep 25, 2015

Np!

@theScrabi
Copy link
Member

Well i could set the title for music streams like you set it for video streams. But all it does is showing the title in the video player activity of VLC. In the audio only activity it displays the url again.

@epitron
Copy link
Contributor Author

epitron commented Sep 26, 2015

I guess each player has specific quirks.

This looks like the point where VLC is getting the title from the intent: https://github.com/mstorsjo/vlc-android/blob/master/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java#L1898

It seems to only check for the intent extras when getAction().equals(PLAY_FROM_VIDEOGRID). I'm not sure what most of this function is doing, but maybe audio is a different action?

@theScrabi
Copy link
Member

That might be it.
Well I don't like VLC for streaming anyway. It has bad audio quality. So I somehow one day want to make a player for NP itself.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

sonarqubecloud bot commented Dec 2, 2024

1 similar comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants