[🐛]: Paracetomol cannot cure irradiated

[BrickedKeyboard]

Was this bug reported before?

• No, it was not.

Are you using Prism or Curseforge?

Yes, I am using Prism or Curseforge.

Have you tried redownloading the pack?

• Not Applicable / Yes, I have tried downloading a new instance.

Computer OS

Win11

Modpack Version Used

0.11.23

Minecraft Environment

Forge Server

New Worlds

Yes

Please provide a link to your latest.log, if relevant.

NA

Expected Behavior

It should be possible to cure the status condition "irradiated" with Paracetomol at high cost.

Actual Behavior

When irradiated reaches 18 seconds, addition Paracetomol pills have no effect. This is probably a bug in the math : 5% of 18 is rounding to zero. Please instead round it up to 1.

Steps to Reproduce

1. Give yourself a piece of radioactive material in survival mode
2. Throw the radioactive material away and give yourself stacks of Paracetomol.
3. Consume Paracetomol. Notice it stops helping the condition at 18 seconds.

Additional Information

No response

[Vykonn]

This is only partially from rounding! Medicine only fully clears when the time healed is greater than 5% left of the total time. This is nearly always true, but not for irradiated! With a 5% chance of healing, it will never be greater. Therefore, it passes it to the second time removal (which is never used in any other case), which rounds. This also means that the descriptions are a complete lie? Paracetamol will always cure carcinogenic, for instance, even though it should only cure 10%.

float time = entry.getFloatValue();
float timeToRemove = time * ((float)this.removePercent / 100.0F);
if (timeToRemove > 0.05F * time) {
    tracker.removeMedicalCondition(condition);
} else {
    tracker.heal(condition, (int)timeToRemove);
}

I think this needs a whole override...

[Pyritie]

I know gtm8 is going to get some improvements to the medical condition system -- I've sent a message to its author in case their changes would also fix this issue. If it won't, it might be worth improving the math in gregtech itself instead of just doing it in a mixin

[screret]

oh. I didn't touch the curing at all, do fix it if you can

[screret]

Medicine only fully clears when the time healed is greater than 5% left of the total time

that's supposed to clear when it's less than 5%. oops. lol. lmao, even. wait no disregard that I cant read
also, the percentages aren't chances, they're the amount of time it'll clear. That should probably be reworked, be my guest.

[Vykonn]

What is the intended behavior supposed to be? If it is e.g. 50% of CURRENT effect the effectiveness of medication decreases the more you have, making it take wayyy too long. if it's e.g. 50% of MAX effect that makes a lot more sense but may be a little harder to implement. @screret