Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine Core Platform Support #584

Closed
CharliePoole opened this issue May 4, 2020 · 4 comments
Closed

Engine Core Platform Support #584

CharliePoole opened this issue May 4, 2020 · 4 comments
Assignees

Comments

@CharliePoole
Copy link
Contributor

CharliePoole commented May 4, 2020

NUnit Compatibility Issue

Category: Platform Support
Visibility: Users
Resolution: Unresolved

Description

The NUnit engine core is built for

  • .NET 2.0
  • .NET Standard 2.0
  • .NET Standard 1.6

The TestCentric engine core is built for

  • .NET 2.0
  • .NET 4.0
  • .NET Standard 2.0
  • .NET Standard 1.6
@ChrisMaddock
Copy link

See nunit/nunit-console#770 for NUnit Engine discussion.

@CharliePoole - is there a particular "incompatability" here, as opposed to just a difference in code? Does the TestCentric engine core assembly make use of any .NET 4.0 specfic functionality, which requires a .NET 4.0 build over .NET 2.0?

@CharliePoole
Copy link
Contributor Author

@ChrisMaddock Maybe you're right. I don't know of any special functionality that is used, since I basically just re-targeted the 2.0 build without change. Since we added a .NET 4.0 agent for NUnit, the tests will run on that with the engine core asembly runnning under whatever version of the 4.x framework the user has installed.

I put this in because it was a difference at least but maybe not an incompatibility. The reason I did it was because some set of assemblies was going to be copied into the .NET 4.0 agent directory for distribution and I figured I might as well build for 4.0. Maybe the resolution is to do nothing.

@jnm2 @mikkelbu Do you have any thoughts on this?

@CharliePoole
Copy link
Contributor Author

@ChrisMaddock I'm ready to close this one if you are.

@ChrisMaddock
Copy link

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants