Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify test run parameters on command-line #706

Closed
CharliePoole opened this issue May 14, 2021 · 13 comments · Fixed by #937 or #938
Closed

Specify test run parameters on command-line #706

CharliePoole opened this issue May 14, 2021 · 13 comments · Fixed by #937 or #938
Assignees
Labels
Feature A new feature. Normal Priority Normal priority issue
Milestone

Comments

@CharliePoole
Copy link
Contributor

This came up in the discussion of #703 as something that may be useful.

We should allow syntax similar to NUnit-Console...

--param name=value OR
-p name=value

Each use may only supply one parameter but the option may appear multiple times. The entire list is added to the TestPackage on load and remains active unless the user makes changes in the GUI parameters dialog.

@CharliePoole CharliePoole added Feature A new feature. Normal Priority Normal priority issue labels May 14, 2021
@CharliePoole CharliePoole added this to the 2.0.0 milestone May 14, 2021
@CharliePoole
Copy link
Contributor Author

@YashUoM Would you be interested in working on this?

@YashUoM
Copy link
Contributor

YashUoM commented May 14, 2021

Sounds great. But my schedule is pretty packed up till the middle of June. After that I can work on this. :)

@CharliePoole
Copy link
Contributor Author

That would be great.

@CharliePoole CharliePoole modified the milestones: 2.0.0, 2.1.0 May 14, 2021
@CharliePoole
Copy link
Contributor Author

@YashUoM Are you still interested in working on this? I'm looking at growing the team so it's not so dependent on me!

@YashUoM
Copy link
Contributor

YashUoM commented Sep 11, 2021

Hi Charlie,
How is the deadline for this?

@CharliePoole
Copy link
Contributor Author

It's not a critical feature, so there's no big hurry. I could suggest how to break it into small steps, in case you can only devote a small amount of time each week to working on it. So it's a question of how much time and interest you have.

@YashUoM
Copy link
Contributor

YashUoM commented Sep 14, 2021

I can work 6-10 hours a week given my day job taking my week days. If that's enough I'll start on this. :-)

@CharliePoole
Copy link
Contributor Author

CharliePoole commented Sep 14, 2021

Definitely! I have assigned it to you. I'll add you to the team as well, which will give you commit authority, but I want to send you some info about how we operate first. If you send me a note, I'll reply with what you need to know to get started.

@immeraufdemhund
Copy link
Contributor

immeraufdemhund commented Sep 14, 2021 via email

@CharliePoole
Copy link
Contributor Author

@immeraufdemhund Indeed! But still plenty of stuff left to do if you feel like becoming active again. :-)

@YashUoM
Copy link
Contributor

YashUoM commented Sep 14, 2021

Sure. Will drop a mail. And I copied your mail. You can remove it from the comment if you want. :-)

@CharliePoole
Copy link
Contributor Author

CharliePoole commented Feb 2, 2023

I'm reopening this. The code I added does solve the problem, but only partially. The gui model creates a test package containing the proper TestParametersDictionary setting used by current versions of NUnit but without TestParameters, used by some older versions.

Underlying this is the fact that creation of the test package resides within the model assembly as does the definition of the supported command-line options. There is a need for some serious refactoring to get these definitions to live where they belong, but that's a good thing as it will simplify the model. I'll create a separate issue for that, however.

@CharliePoole
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.0.0-alpha7 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature. Normal Priority Normal priority issue
Projects
None yet
3 participants