Skip to content

Conversation

@jeevantelukula
Copy link
Collaborator

Add the documentation for the new Webserver Demo added showcasing the audio analytics and performance stats.

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some warnings from vales could also be looked into

@github-actions
Copy link

New warnings found with rstcheck:

source/linux/Demo_User_Guides/Webserver_Demo_User_Guide.rst:112: (ERROR/3) (bash) syntax error near unexpected token `newline'
source/linux/Demo_User_Guides/Webserver_Demo_User_Guide.rst:112: (ERROR/3) (bash) `    filesink buffer-mode=2 location=<fifo_path>'

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#542 (comment) needs to be addressed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind scaling the window a little before taking these screenshots? Normally I'm a fan of 16:9 ratios, but there's a lot of dead space on this page and png compression can only do so much work here.

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the suggestions. The v2 is in much better shape.
There are couple of minor fixes needed, post which the PR is good to go

Add the documentation for the new Webserver Demo added
showcasing the audio analytics and performance stats.

Signed-off-by: Telukula Jeevan Kumar Sahu <[email protected]>
@jeevantelukula
Copy link
Collaborator Author

Updated the PR according to the review comments

Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly fine with this. The image sizes, while being rather large are still under the current mean size. I just fear that the scaled versions will still be hard to see considering the amount of dead space. Feel free to update this if you agree.

Software Architecture
*********************

The demo is comprised of three main components: a web interface, a backend web server, and a set of Linux applications.
Copy link
Member

@StaticRocket StaticRocket Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The demo is comprised of three main components: a web interface, a backend web server, and a set of Linux applications.
The demo consists of three main components: a web interface, a backend web server, and a set of Linux applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants