-
Notifications
You must be signed in to change notification settings - Fork 75
feat(AM335X): Add webserver demo user guide #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(AM335X): Add webserver demo user guide #542
Conversation
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some warnings from vales could also be looked into
0470f37 to
ec79299
Compare
|
New warnings found with rstcheck: |
ec79299 to
d7800ee
Compare
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#542 (comment) needs to be addressed
d7800ee to
d1000b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind scaling the window a little before taking these screenshots? Normally I'm a fan of 16:9 ratios, but there's a lot of dead space on this page and png compression can only do so much work here.
cshilwant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling the suggestions. The v2 is in much better shape.
There are couple of minor fixes needed, post which the PR is good to go
Add the documentation for the new Webserver Demo added showcasing the audio analytics and performance stats. Signed-off-by: Telukula Jeevan Kumar Sahu <[email protected]>
d1000b8 to
29e05e9
Compare
|
Updated the PR according to the review comments |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mostly fine with this. The image sizes, while being rather large are still under the current mean size. I just fear that the scaled versions will still be hard to see considering the amount of dead space. Feel free to update this if you agree.
| Software Architecture | ||
| ********************* | ||
|
|
||
| The demo is comprised of three main components: a web interface, a backend web server, and a set of Linux applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The demo is comprised of three main components: a web interface, a backend web server, and a set of Linux applications. | |
| The demo consists of three main components: a web interface, a backend web server, and a set of Linux applications. |
Add the documentation for the new Webserver Demo added showcasing the audio analytics and performance stats.