forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 84
Open
Labels
BugSomething is not working right, typically is user facingSomething is not working right, typically is user facingGUIFor graphical user interfaceFor graphical user interfaceMinorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerNetworkAnything related to network, serversAnything related to network, servers
Description
Sorting logic is wrong in GameSortStruct::operator()
with g2Good
.
struct GameSortStruct
{
bool operator()(GameSpyStagingRoom *g1, GameSpyStagingRoom *g2) const
{
// sort CRC mismatches to the bottom
Bool g1Good = (g1->getExeCRC() != TheGlobalData->m_exeCRC || g1->getIniCRC() != TheGlobalData->m_iniCRC);
Bool g2Good = (g1->getExeCRC() != TheGlobalData->m_exeCRC || g1->getIniCRC() != TheGlobalData->m_iniCRC); // <--- wrong
if ( g1Good ^ g2Good )
{
return g1Good;
}
...
Metadata
Metadata
Assignees
Labels
BugSomething is not working right, typically is user facingSomething is not working right, typically is user facingGUIFor graphical user interfaceFor graphical user interfaceMinorSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < BlockerNetworkAnything related to network, serversAnything related to network, servers