Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underline if there's no feature media photo caption? #247

Open
phillipadsmith opened this issue Jul 7, 2016 · 2 comments
Open

Remove underline if there's no feature media photo caption? #247

phillipadsmith opened this issue Jul 7, 2016 · 2 comments
Assignees

Comments

@phillipadsmith
Copy link
Member

phillipadsmith commented Jul 7, 2016

What to do here, Gents:
http://preview.thetyee.ca/Opinion/2016/05/24/UBC-Let-Students-Live-on-Campus/
http://preview.thetyee.ca/News/2015/12/17/Peace-Valley-Construction/index.html

@MrBryan
Copy link
Collaborator

MrBryan commented Jul 7, 2016

I set to detect outside the figcaption so the element won't be there now when there is no caption (repreviewed those two)

@MrBryan MrBryan closed this as completed Jul 7, 2016
@alexgreen alexgreen reopened this Jul 9, 2016
@alexgreen
Copy link
Contributor

@MrBryan something is injected a 30px margin-bottom into the featured-media section in these cases, creating a big gap above the article__body:
<section class="featured-media" data-dev-object-descrip="02-organisms/article/featured-media" style="margin-bottom: 30px;">

Is there a reason for this? If not, please remove the margin. If so, please apply the margin via a css class so that it can be controlled along with the other object styling.

Either way, it would be useful if you could apply a .featured-media--no-caption class extension:
<section class="featured-media featured-media--no-caption" data-dev-object-descrip="02-organisms/article/featured-media">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants