Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a "Shared" counter #319

Open
phillipadsmith opened this issue Aug 2, 2016 · 78 comments
Open

Implement a "Shared" counter #319

phillipadsmith opened this issue Aug 2, 2016 · 78 comments

Comments

@phillipadsmith
Copy link
Member

Per Basecamp thread, the request is to implement a count of shares across networks and display that on article pages, presumably near the share tools.

@robynleighsmith Can you put links to the examples we looked at in the office here?

@robynleighsmith
Copy link

I think we just looked at the Guardian and the CBC. Not sure how either are calculated.

In the two examples below, both of the share options are on the left.

https://www.theguardian.com/world/2016/aug/02/chlorine-attack-syria-dozens-ill-saraqeb-idlib

http://www.cbc.ca/news/world/obama-trump-1.3704157

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

OK here it is in testing mode (should show up in any story you newly test with the numbers that actually will show if it went live.

The free version is limited to 10,000 views per day or something so we'd need the $40 a month version that does up to 200,000 ( we get around 30,000 pageviews from memory..)

http://preview.thetyee.ca/Opinion/2016/08/05/Farewell-to-Mel-Hurtig/

image

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

We could add the count of the email to friend likely with a little effort if that is significant - currently it's counting facebook (shares - likes also available), twitter, linkedin, reddit.

@robynleighsmith
Copy link

Thanks Bryan. To be crystal clear, what does this version count, specifically? Just Facebook shares? Does it cost more to count likes? And to include the other share numbers?

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

Nope it costs the same just more code to add facebook likes - it counts all that I listed above you probably typed that before my second comment :)

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

We have all the numbers separately I'm just adding them up -- could do something like this alternately:
image

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

and when i say newly test, I mean that if you preview a story from bricolage the number should show up now

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

the number for the live version of the story

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

it breaks the toolbar onto two lines for mobile so that will have to be tweaked just think of this as a draft for comment

@robynleighsmith
Copy link

Okay, so the current number being previewed shows Facebook likes, shares, Google +, and whatever "Submit" is? It doesn't include comments, obviously.

Also, it doesn't show up on this preview: http://preview.thetyee.ca/Opinion/2016/08/02/BC-Terror-Trial-Verdict/

@robynleighsmith
Copy link

Put another way, the current number showing in preview is the sum total of all those things?

@robynleighsmith
Copy link

Also, there's no free version of this? I think we got Facebook shares shown for free before the redesign.

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

oh no that "submit" thing is just a picture from HuffPo's share bar that means nobody has posted to reddit yet instead of showing zero. We are combining facebook , twitter, reddit, linkedin, google+.

I thought this one had addressed the twitter thing but it seems not so perhaps it is not worth the fee (twitter counts don't work since twitter turned off access to that data.) I thought I remembered a directive saying let's go with sharedcount for now is why I started there.

There are people who provide the service of twitter counts presumably so that they can mine your data that we could investigate if that is important:

http://twitcount.com/
https://opensharecount.com/

And there is probably a free way of getting those (non-twitter) counts, either by coding myself or using a third party toolbar provider (normally they provide you with sharing statistics and also mine your data of course) like http://www.addthis.com/

@robynleighsmith
Copy link

robynleighsmith commented Aug 5, 2016

Okay, so this "SharedCount" that you're previewing now includes Facebook shares and likes, reddit, linkedin and google+. Not Twitter, because no one can get Twitter. And it will cost $40 a month because we have received more than 10,000 views daily.

Do I have this right? (sorry if this is like hitting your head against a brick wall repeatedly).

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 5, 2016

Yes that is right except that some people are claiming they can approximate twitter- twitcount and opensharecount among others - they are free so could experiment or investigate more if we find that twitter is important to have in the mix.

That aside, If we want to avoid the $40 fee I can look at how to look up each of those numbers ourselves in code rather than use their simplified service, probably will pay off in the long run just whether to spend the time now is the question.,

@robynleighsmith
Copy link

Well, we may as well use this solution for now (including paying the $40 fee), as it will probably take time to code our own version. Thanks for the investigation, Bryan. I'll just wait to give @phillipadsmith to say his piece before giving the official go-ahead.

@phillipadsmith
Copy link
Member Author

phillipadsmith commented Aug 5, 2016

Wow, this is a crazy-long thread... :-/

Few quick thoughts:

  1. Agree that we should move forward with what is easiest for the moment, including the $40 fee, which is very low compared to development time costs.
  2. It would be easy enough to aggregate the counts we care about and run that on The Tyee's infrastructure for free within a year, e.g., focus on just Facebook, Twitter, and Reddit if that's interesting.
  3. We should not go down the ShareThis/AddThis path again because we know that it A) impacts the load time of the site, and B) doesn't count accurately (counts button clicks, not actual shares), and C) looks super ugly. Right now, the custom buttons let Eric track interactions closely in Google Analytics, which is what we wanted.
  4. I'd propose we should throw in the e-mail share count because we know that LOTS of Tyee readers use that tool, and the data is easy to get, e.g., https://github.com/phillipadsmith/widgets.thetyee.ca <-- BTW, Bryan, it looks like the widgets.thetyee.ca service is down for some reason (probably the load the other day), would you be so kind as to re-start it?

Over and out for now. :-)

@robynleighsmith
Copy link

All right, it's agreed. For now, we moved ahead with Shared Count, which includes the gamut of shares except for Twitter. (@MrBryan, let me know if you need me to input credit card data for the $40 somewhere.)

@phillipadsmith, I'm assuming the email share count would not be included in the total Shared Count counter, but rather in a separate way?

@phillipadsmith
Copy link
Member Author

@phillipadsmith, I'm assuming the email share count would not be included in the total Shared Count counter, but rather in a separate way?

I believe it would be easy enough to include the e-mail share count in that single number, as well as Twitter.

@robynleighsmith
Copy link

Let's do it then!

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 8, 2016

OK Sent the login info your email @robynleighsmith . Alex offered to do the styling for this although not this week. If we want to get it out sooner I can work something out quickly in the interim

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 8, 2016

I should say pehaps not this week --- alex?

@robynleighsmith
Copy link

Hm, styling? This is the first I'm hearing of it. Yes, would be good to get a handle on how long that will take.

@phillipadsmith, getting this done is still the priority, yes? Meaning styling the share counters should be a top priority for Alex, too.

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 8, 2016

Yes just some thinking has to be done about what should happen at mobile sizes - the bar is too wide with this element added

image

@phillipadsmith
Copy link
Member Author

FYI, the new endpoints to retrieve aggregate share counts from The Tyee's own internal tools is now live. Documentation is here. Should be sufficient to re-implement the functionality of sharedcount.com.

@phillipadsmith
Copy link
Member Author

These two commits:

Re-implement the shared count with the new service, e.g.,
http://thetyee.github.io/design-article.thetyee.ca/

Ready for deployment, @MrBryan

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 21, 2016

Deployed!

@robynleighsmith
Copy link

@phillipadsmith @MrBryan Looks good, though in mobile view the comments option gets bumped down a line, which doesn't look ideal.

I forget what the fix was when this was happening before?

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 22, 2016

We were just discussing that.. we were saying perhaps see if anyone clicks on the join button from mobile and removing it but i just though of this - how about just removing the shared icon and leaving the count :

image

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 22, 2016

we could do that just to avoid the line jumping for now then let alex weigh in if he wants

@robynleighsmith
Copy link

Sounds good.

On Aug 21, 2016, at 5:51 PM, MrBryan [email protected] wrote:

we could do that just to avoid the line jumping for now then let alex weigh in if he wants


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@MrBryan
Copy link
Collaborator

MrBryan commented Aug 22, 2016

ok that's live too

@phillipadsmith
Copy link
Member Author

Sounds good.

Looks a little disassociated to me, but I'm sure it's fine for the moment.

My current thought is: What about having the number sit on top of a faint icon? Obviously, for popular articles the number would float past the right-most edge of said icon, but I think it would still work.

Over to you, @alexgreen.

@phillipadsmith
Copy link
Member Author

Could also be a typographic treatment, e.g.,: twitter_counts_are_back__and_a_few_other_goodies_-_warfare_plugins

@robynleighsmith
Copy link

Oh Phillip, that looks great!!

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

With the icon still in there it doesn't save us much horizontal real-estate... what do you think of this:

image

http://preview.thetyee.ca/News/2016/09/01/Jims-Story-Holes-In-Downtown-Eastside-Systems/index.html

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

stilil works in the thousands (maybe give tad more horizontal padding)

image

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

Trying an option of floating the share icon to the left as you did phillip but outside of the official toolbar boundary:

image

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

to be refined later today just grabbing some late lunch!

@phillipadsmith
Copy link
Member Author

Thank you for this @MrBryan! Personally, I prefer the option without the mini icon and just the text treatment. @robynleighsmith is offline this week, I believe, so we'll need to make the call and move forward and can always re-visit later.

Phillip.

@phillipadsmith
Copy link
Member Author

Oh, and, I didn't mean to include the icon in the screenshot I sent for the reason you stated -- it would not save much space if it was there! Oversight on my part.

@robynleighsmith
Copy link

@phillipadsmith @MrBryan Look at me, back from the offline grave! I agree with Phillip and prefer the option without the icon. Text treatment works. Thanks!

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

OK she's live :)

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

... with better alignment with bottom and consistent spacing like the other icons to each other

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

image

@phillipadsmith
Copy link
Member Author

Woo hoo!

And does that work acceptably on smaller screens now too?

Phillip.

On Sep 1, 2016, at 2:00 PM, MrBryan [email protected] wrote:

https://cloud.githubusercontent.com/assets/1721891/18184134/91593ed2-7065-11e6-9099-349903f7eee1.png

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #319 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AACFUIMjA_371ARYvM03UBXMB3TqX1ndks5qlzzngaJpZM4JaOtX.

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 1, 2016

yes except because of the print icon it overflows so going to hide that on mobile too

@phillipadsmith
Copy link
Member Author

yes except because of the print icon it overflows so going to hide that on mobile too
👍

@robynleighsmith
Copy link

@MrBryan @phillipadsmith I am so thrilled by how this turned out. Thank you both!!

@phillipadsmith
Copy link
Member Author

LOL.

It’s Sunday, @robinleighsmith! Turn off the Internet. Go outside and play. ;-)

On Sep 4, 2016, at 5:15 PM, robynleighsmith [email protected] wrote:

@MrBryan https://github.com/MrBryan @phillipadsmith https://github.com/phillipadsmith I am so thrilled by how this turned out. Thank you both!!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #319 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AACFUKkw2NIYJntPP5I_0kxPE3AASiTCks5qm18WgaJpZM4JaOtX.

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 5, 2016

Speak for yourself, I prefer that my coworkers thank and praise me all weekend long

On Sep 4, 2016, at 8:23 PM, Phillip Smith [email protected] wrote:

LOL.

It’s Sunday, @robinleighsmith! Turn off the Internet. Go outside and play. ;-)

On Sep 4, 2016, at 5:15 PM, robynleighsmith [email protected] wrote:

@MrBryan https://github.com/MrBryan @phillipadsmith https://github.com/phillipadsmith I am so thrilled by how this turned out. Thank you both!!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #319 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AACFUKkw2NIYJntPP5I_0kxPE3AASiTCks5qm18WgaJpZM4JaOtX.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@MrBryan
Copy link
Collaborator

MrBryan commented Sep 5, 2016

And of course you're welcome, it was fun as usual :)

Sent from my iPhone

On Sep 5, 2016, at 1:22 AM, Bryan Carney [email protected] wrote:

Speak for yourself, I prefer that my coworkers thank and praise me all weekend long

On Sep 4, 2016, at 8:23 PM, Phillip Smith [email protected] wrote:

LOL.

It’s Sunday, @robinleighsmith! Turn off the Internet. Go outside and play. ;-)

On Sep 4, 2016, at 5:15 PM, robynleighsmith [email protected] wrote:

@MrBryan https://github.com/MrBryan @phillipadsmith https://github.com/phillipadsmith I am so thrilled by how this turned out. Thank you both!!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #319 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AACFUKkw2NIYJntPP5I_0kxPE3AASiTCks5qm18WgaJpZM4JaOtX.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants