Adjust code to display high/low temps in forecast?

[jurassic73]

Missing feature

High/Low temperature display in forecast?

Justification

I currently see what looks like the low temperature displayed only in the forecast view. Curious if this can be adjusted to display both the high and low temperatures in the forecast view? If I configure the following, I see tempMin twice which is the same value returned for temp:

String temp = String(forecasts[dayIndex].tempMin, 0) + ("/") + String(forecasts[dayIndex].tempMax, 0) + (IS_METRIC ? "°C" : "°F");

I just need to know what to change to pull the tempMin and tempMax through from the API call

Workarounds

None

[NeTgHoStKiLlEr]

I have the same Issue. It appears to be showing forecast data for night-time only, even the weather icons are in night-mode; showing moons instead of suns. Been working at this to try and finish before Fathers Day...!

As you can see, the Current Weather data is fine, but it then decides to show only night-time data for the forecast.

[marcelstoer]

The min / max is actually "broken" (our opinion) in the OWM API, see #172.

[NeTgHoStKiLlEr]

Should I open another Issue topic for my slightly different issue? I just don't understand why its showing moon icons during the day. I wouldn't even care if it showed the projected forecast for only one hour of the next three days, just that it needs to show daytime temps; it gets HOT here. That shouldn't have anything to do with the temp_min or temp_max confusion.. correct?

I'm guessing somewhere in this function, having something to do with the ObservationTimeStamp or DayIndex values is where the issue lies?

void drawForecastDetails(OLEDDisplay *display, int x, int y, int dayIndex) {
  time_t observationTimestamp = forecasts[dayIndex].observationTime;
  struct tm* timeInfo;
  timeInfo = localtime(&observationTimestamp);
  display->setTextAlignment(TEXT_ALIGN_CENTER);
  display->setFont(ArialMT_Plain_10);
  display->drawString(x + 20, y, WDAY_NAMES[timeInfo->tm_wday]);

  display->setFont(Meteocons_Plain_21);
  display->drawString(x + 20, y + 12, forecasts[dayIndex].iconMeteoCon);
  String temp = String(forecasts[dayIndex].temp, 0) + (IS_METRIC ? "°C" : "°F");
  display->setFont(ArialMT_Plain_10);
  display->drawString(x + 20, y + 34, temp);
  display->setTextAlignment(TEXT_ALIGN_LEFT);
}

I don't need the high/low for the current day, just need the 3 day forecast to show daytime temps instead of night. Ty!

EDIT: I suspect the original code was meant to get the current time of day, and show either Day or Night forecast data based on if its morning or afternoon time. This is the part that I can't find how it works to correct it.

[marcelstoer]

Looks like I misinterpreted the issue at first.

[NeTgHoStKiLlEr]

Well, the OP wanted additional functionality to display both night and day high/low temps at the same time. I just added onto this issue because I thought he realized it wasn't only supposed to show the low/night time temps during the day. I don't think he does, now. Hence me wondering if I should create a NEW topic! :)

[KevinGroninga]

I too am having the same issue with the forecast temps appearing to be the low temps for each of the three days. Living in Phoenix Arizona, our concern is more with high temps for a given day (as you could imagine.) There was a previous request to display both Min and Max. I agree that would be ideal.

I did a little research and debugging on my own and took a look at the data being returned by the API from OpenWeatherMap. Very, very odd. It appears that for forecast data, it's sending data in 3 hour increments. So you're actually getting 8 different data sets for a given data. It also appears that in my case with the timezone offset that it's using the temp data from the 12:00 hour (middle of the day), but yet those temps appear to be the absolute lowest. So appears there's some sort of time offset issue as well.

Having said that, would it make any sense to look at all 8 data elements within a given forecast day and do some comparisons and then capture the highest temp_max value as well as the lowest temp_min value and use those to display?

Really would like to have this working...

Perhaps instead of having just one page with all three of the forecast days, we could fit more info for each day by having a separate page for each?

[KevinGroninga]

Oh, just another thing I saw in the OpenWeatherMapForecast.cpp file. This 'could' potentially be part of the issue. Since I'm not an Arduino code developer, I'm not 100% certain. But in the following code, is there any accounting for the 'TZ' offset that was defined in the WeatherStationDemo sketch?

 if (allowedHoursCount > 0) {
      time_t time = data[currentForecast].observationTime;
      struct tm* timeInfo;
      **timeInfo = gmtime(&time);
      uint8_t currentHour = timeInfo->tm_hour;**
      for (uint8_t i = 0; i < allowedHoursCount; i++) {
        if (currentHour == allowedHours[i]) {
          isCurrentForecastAllowed = true;
          return;
        }
      }

[marcelstoer]

is there any accounting for the 'TZ' offset

I wondered as well the other day. gmtime returns UTC.

[KevinGroninga]

Well, this has been disappointing. Went to some effort to put this together and even designed a 3D printed enclosure for it, the charge controller and small 3.7v battery. Now come to find out, the forecast info is basically useless. Hmmmm...

[marcelstoer]

Maybe there's both a conceptual and a coding problem (not sure, haven't been around this code for a while).

With https://github.com/ThingPulse/esp8266-weather-station/blob/master/examples/OpenWeatherMapForecastDemo/OpenWeatherMapForecastDemo.ino#L101-L102

  uint8_t allowedHours[] = {0,12};
  client.setAllowedHours(allowedHours, 2);

you're basically limiting the forecasts to midnight and noon. I guess this assumes that min temp is around midnight and high temp around noon. For many places this is likely not true.
The coding problem then maybe is that 0/12 doesn't consider the timezone.