"." is interpreted as regex

[roland-KA]

I would like to remove an occurence of a dot inside a string. Therefore I used the following expression:

str_remove("345.67", ".")

The result is not "34567" as expected, but "45.67". str_remove seems to interpret "." as a regular expression, even if there is no r-prefix (like in r".").

So I have to do

str_remove("345.67", "\\.")

to get the intended behaviour.

Shouldn't "." be interpreted just as a string as it has no r-prefix?

[drizk1]

This is absolutely a bug. Thank you for catching it.

If you already have a fix ready, I'm happy to merge a pr. If not, I'll get it fixed for you.

[roland-KA]

Thanks @drizk1 for the fast response! Would be nice, if you could fix it.

[drizk1]

Will try to have a fix in the next 48 hours.

[roland-KA]

Thanks a lot! The Tidier-team is always blazingly fast – really incredible 👍🥇

[drizk1]

This should hopefully be resolved now. There might be a few other place that issue is lurking, so i will try to root them all out before merging and releasing.

Feel free to try

julia> ]add TidierStrings#regeex-fix

julia> str_remove("345.67", ".")
"34567"

julia> str_remove("345.67", r".")
"45.67"

[roland-KA]

Thanks, this works now very well!

But I found another issue, which has probably the same cause. If I replace the character + within a string with the following expression:

str_replace("+-000", "+", "")

I don't get "-000" as expected, but the following error message:

WARNING: redefinition of constant TidierStrings.docstring_str_remove_all. This may fail, cause incorrect answers, or produce other errors.
ERROR: PCRE compilation error: quantifier does not follow a repeatable item at offset 0
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] compile(pattern::String, options::UInt32)
   @ Base.PCRE ./pcre.jl:165
 [3] compile(regex::Regex)
   @ Base ./regex.jl:86
 [4] Regex(pattern::SubString{String}, compile_options::UInt32, match_options::UInt32)
   @ Base ./regex.jl:40
 [5] Regex(pattern::SubString{String})
   @ Base ./regex.jl:74
 [6] str_replace(column::String, pattern::String, replacement::String)
   @ TidierStrings ~/.julia/packages/TidierStrings/Df0eZ/src/matching.jl:98
 [7] top-level scope
   @ REPL[67]:1

[drizk1]

this should be fixed as well now, please let me know if others come up

julia> str_replace("+-000", "+", "")
"-000"

[roland-KA]

Yes perfect, that works now! Thanks!