Skip to content

Commit cf48b23

Browse files
committed
new arrow benchmarks report solution as R-arrow
1 parent a493b3b commit cf48b23

File tree

8 files changed

+16
-15
lines changed

8 files changed

+16
-15
lines changed

arrow/groupby-arrow.R renamed to R-arrow/groupby-R-arrow.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ suppressPackageStartupMessages({
1313
ver = packageVersion("arrow")
1414
git = ""
1515
task = "groupby"
16-
solution = "arrow"
16+
solution = "R-arrow"
1717
fun = "group_by"
1818
cache = TRUE
1919
on_disk = FALSE

arrow/join-arrow.R renamed to R-arrow/join-R-arrow.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ suppressPackageStartupMessages({
1212
ver = packageVersion("arrow")
1313
git = ""
1414
task = "join"
15-
solution = "arrow"
15+
solution = "R-arrow"
1616
cache = TRUE
1717
on_disk = FALSE
1818

R-arrow/setup-R-arrow.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
#!/bin/bash
2+
set -e
3+
4+
# install stable arrow
5+
mkdir -p ./arrow/r-arrow
6+
Rscript -e 'install.packages(c("arrow","dplyr"), lib="./R-arrow/r-arrow")'

arrow/upg-arrow.sh renamed to R-arrow/upg-R-arrow.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ set -e
33

44
# upgrade all packages in arrow library only if new arrow is out
55
echo 'upgrading arrow...'
6-
Rscript -e 'ap=available.packages(); if (ap["arrow","Version"]!=packageVersion("arrow", lib.loc="./arrow/r-arrow")) update.packages(lib.loc="./arrow/r-arrow", ask=FALSE, checkBuilt=TRUE, quiet=TRUE)'
6+
Rscript -e 'ap=available.packages(); if (ap["arrow","Version"]!=packageVersion("arrow", lib.loc="./R-arrow/r-arrow")) update.packages(lib.loc="./arrow/r-arrow", ask=FALSE, checkBuilt=TRUE, quiet=TRUE)'

R-arrow/ver-R-arrow.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/bin/bash
2+
set -e
3+
4+
Rscript -e 'v=read.dcf(system.file(package="arrow", lib.loc="./R-arrow/r-arrow", "DESCRIPTION"), fields=c("Version","RemoteSha")); colnames(v)[colnames(v)=="RemoteSha"]="Revision"; cnafill=function(x) {x=c(x); x[is.na(x)]=""; x}; fw=function(f, v) writeLines(v, file.path("arrow", f)); invisible(mapply(fw, toupper(colnames(v)), cnafill(v)))'

_report/report.R

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ clean_time = function(d) {
6969
if (nrow(d[!nzchar(version) | is.na(version)]))
7070
stop("timings data contains NA or '' as version field, that should not happen")
7171
old_advanced_groupby_questions = c("median v3 sd v3 by id2 id4","max v1 - min v2 by id2 id4","largest two v3 by id2 id4","regression v1 v2 by id2 id4","sum v3 count by id1:id6")
72+
73+
# replace arrow with R-arrow (see https://github.com/duckdblabs/db-benchmark/pull/66)
74+
d[solution == "arrow", solution := "R-arrow"]
7275
d[!nzchar(git), git := NA_character_
7376
][,"on_disk" := as.logical(on_disk)
7477
][task=="groupby" & solution%in%c("pandas","dask","spark") & batch<1558106628, "out_cols" := NA_integer_
@@ -244,8 +247,6 @@ transform = function(ld) {
244247

245248
time_logs = function(path=getwd()) {
246249
lt <- load_time(path=getwd())
247-
# replace arrow with R-arrow (see https://github.com/duckdblabs/db-benchmark/pull/66)
248-
lt$solution[lt$solution == "arrow"] <- "R-arrow"
249250

250251
ct = clean_time(lt)
251252
d = model_time(ct)

arrow/setup-arrow.sh

Lines changed: 0 additions & 6 deletions
This file was deleted.

arrow/ver-arrow.sh

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)