fix

Author: erindru

.circleci/manage-test-db.sh

@@ -51,7 +51,7 @@ databricks_init() {
 
     # Note: the cluster doesnt need to be running to create / drop catalogs, but it does need to be running to run the integration tests
     echo "Ensuring cluster is running"
-    databricks clusters start $CLUSTER_ID || true
+    databricks clusters start $CLUSTER_ID
 }
 
 databricks_up() {

sqlmesh/core/engine_adapter/fabric.py

@@ -179,9 +179,11 @@ def create_warehouse(
     ) -> None:
         """Create a catalog (warehouse) in Microsoft Fabric via REST API."""
 
-        # attempt count is arbitrary, it essentially equates to 30 seconds max wait with the time.sleep() below
-        if attempt > 3:
-            raise SQLMeshError("Gave up waiting for warehouse to become available")
+        # attempt count is arbitrary, it essentially equates to 5 minutes of 30 second waits
+        if attempt > 10:
+            raise SQLMeshError(
+                f"Gave up waiting for Fabric warehouse {warehouse_name} to become available"
+            )
 
         logger.info(f"Creating Fabric warehouse: {warehouse_name}")
 
@@ -202,9 +204,11 @@ def create_warehouse(
                 return
             if errorCode == "ItemDisplayNameNotAvailableYet":
                 logger.warning(f"Fabric warehouse {warehouse_name} is still spinning up; waiting")
-                time.sleep(
-                    10
-                )  # arbitrary, seems to be "good enough" at least in CI. I was unable to find any guidance in the MS docs on how to handle this case
+                # Fabric error message is something like:
+                #  - "Requested 'circleci_51d7087e__dev' is not available yet and is expected to become available in the upcoming minutes."
+                # This seems to happen if a catalog is dropped and then a new one with the same name is immediately created.
+                # There appears to be some delayed async process on the Fabric side that actually drops the warehouses and frees up the names to be used again
+                time.sleep(30)
                 return self.create_warehouse(
                     warehouse_name=warehouse_name, if_not_exists=if_not_exists, attempt=attempt + 1
                 )

tests/core/engine_adapter/integration/test_integration.py

@@ -3610,7 +3610,10 @@ def _set_config(_gateway: str, config: Config) -> None:
 
     # check physical objects
     snapshot_table_name = exp.to_table(new_model.table_name(), dialect=ctx.dialect)
-    snapshot_schema = snapshot_table_name.db
+    snapshot_schema = parsed_schema.copy()
+    snapshot_schema.set(
+        "db", exp.to_identifier(snapshot_table_name.db)
+    )  # we need this to be catalog.schema and not just schema for environment_suffix_target: catalog
 
     prod_schema = normalize_identifiers(d.to_schema(schema), dialect=ctx.dialect)
     dev_env_schema = prod_schema.copy()