You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we need to think carefully about this dictionary. Firstly, we know we want to store other things about widgets in later PRs, including their widget number #95. Therefore I would consider whether a 'widget_properties' dictionary could be a better plan, structured something like:
self.widget_properties = { 'widget_name': {'default': , 'widget_number': }, .... }
(or with some snappier/better name for widget_number)
and could include other information as we think of it, that could be useful.
Then the 'default' section of that dict would hold a dictionary that contains the default state:
@DanicaSTFC and I discussed the benefits of separating the default state from the widget number, and store them in different places.
This would include being able to take one widget with its defaults and add to a different form easily without bringing across also widget position.
The text was updated successfully, but these errors were encountered:
We will include the widget number in the dictionary (for both states and default states) in this PR
DanicaSTFC
changed the title
Default states dictionary and other properties of widgets conventions
Default-states dictionary and other properties of widgets conventions
Nov 30, 2023
From @lauramurgatroyd
I think we need to think carefully about this dictionary. Firstly, we know we want to store other things about widgets in later PRs, including their widget number #95. Therefore I would consider whether a 'widget_properties' dictionary could be a better plan, structured something like:
self.widget_properties = { 'widget_name': {'default': , 'widget_number': }, .... }
(or with some snappier/better name for widget_number)
and could include other information as we think of it, that could be useful.
Then the 'default' section of that dict would hold a dictionary that contains the default state:
eqt/eqt/ui/UIFormWidget.py
Lines 170 to 173 in ec2c5a1
Originally posted by @lauramurgatroyd in #97 (comment)
#97 (comment)
@DanicaSTFC and I discussed the benefits of separating the default state from the widget number, and store them in different places.
This would include being able to take one widget with its defaults and add to a different form easily without bringing across also widget position.
The text was updated successfully, but these errors were encountered: