Skip to content

Commit 72f3a04

Browse files
fix: Downgrade AWS SDK packages and crc-fast for Rust 1.87.0 compatibility
The crc-fast crate version 1.6.0+ requires Rust features that are only available in Rust 1.88+. Additionally, several AWS SDK packages and the home crate released after May 2025 require Rust 1.88.0+. Since Rust 1.88.0 is not yet available in the Nix rust-overlay, we downgrade to compatible versions: - aws-config: 1.8.10 → 1.8.0 - aws-sdk-s3: 1.112.0 → 1.107.0 - aws-sdk-sso: 1.89.0 → 1.86.0 - aws-sdk-ssooidc: 1.91.0 → 1.88.0 - aws-sdk-sts: 1.92.0 → 1.89.0 - aws-smithy-checksums: 0.63.11 → 0.63.10 - crc-fast: 1.6.0 → 1.3.0 - home: 0.5.12 → 0.5.11 This keeps Rust at 1.87.0 while avoiding the unstable feature error: error[E0658]: use of unstable library feature `stdarch_x86_avx512` Fixes the following CI failures: - coverage/ (Nix build failure) - publish-image/ (Docker image build failure) - asan-ubuntu-24/ (ASAN test failure)
1 parent f8071ef commit 72f3a04

File tree

4 files changed

+39
-38
lines changed

4 files changed

+39
-38
lines changed

Cargo.lock

Lines changed: 36 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,9 @@ resolver = "2"
1010
[package]
1111
edition = "2024"
1212
name = "nativelink"
13-
rust-version = "1.88.0"
13+
rust-version = "1.87.0"
1414
version = "0.7.6"
1515

16-
[package.metadata.cargo-machete]
17-
ignored = ["crc-fast"]
18-
1916
[profile.release]
2017
lto = true
2118

@@ -77,10 +74,6 @@ tonic = { version = "0.13.0", features = [
7774
tower = { version = "0.5.2", default-features = false }
7875
tracing = { version = "0.1.41", default-features = false }
7976

80-
# Pin crc-fast to avoid unstable features in 1.6.0+
81-
# See: https://github.com/rust-lang/rust/issues/111137
82-
crc-fast = { version = "=1.3.0", default-features = false }
83-
8477
[workspace.cargo-features-manager.keep]
8578
async-lock = ["std"]
8679
aws-sdk-s3 = ["rt-tokio"]

clippy.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ disallowed-methods = [
1414
{ path = "tokio::task::spawn_blocking", reason = "use `nativelink-util::task::spawn_blocking` instead" },
1515
{ path = "tokio::task::spawn_local", reason = "use one of the `nativelink-util::task` functions instead" },
1616
]
17-
msrv = "1.88.0"
17+
msrv = "1.87.0"

local-remote-execution/overlays/rust-config.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
let
2-
defaultStableVersion = "1.88.0";
2+
defaultStableVersion = "1.87.0";
33
defaultNightlyVersion = "2025-05-21";
44
in rec {
55
# This map translates execution platforms to sensible targets that can

0 commit comments

Comments
 (0)