Skip to content

fix log dupe at cmd completion - #2694

Merged
amankrx merged 5 commits into
TraceMachina:mainfrom
mridulmanohar:mridul/fix-args-log-dup
Aug 20, 2026
Merged

fix log dupe at cmd completion#2694
amankrx merged 5 commits into
TraceMachina:mainfrom
mridulmanohar:mridul/fix-args-log-dup

Conversation

@mridulmanohar

@mridulmanohar mridulmanohar commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

What and why

At the default RUST_LOG=info level, every action is logging its complete argv twice -
once at running_actions_manager.rs:1487 ("Executing command") and
again at running_actions_manager.rs:1904 ("Command complete").
The 1st time is deliberate looking at the TODO explaining why it is not a debug! instead - 'we often rely on this to figure out toolchain misconfiguration issues'. However, the 2nd time has no such justification and seems to be a duplication. When this line executes, the action is completed but we do not see any useful info which is in context like exit_code. so instead of repeating what is already known it would be helpful to log something useful to correlate. Also this reduces total log size by omitting line duplication.

How was this verified?

the cargo test worker_times_out asserts the info! log statement.
this was run locally to verify that the test case is passing -
$ cargo test -- worker_times_out
running 1 test
test tests::worker_times_out ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.03s

Risk

Severity: low (log operability)
Resulting logs for an action might appear different in terms of debugging prespective from earlier.


This change is Reviewable

@CLAassistant

CLAassistant commented Aug 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nativelink Ready Ready Preview Aug 20, 2026 2:02am
nativelink-aidm Ready Ready Preview Aug 20, 2026 2:02am

Request Review

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Some of the pull request description still needs filling in:

  • How was this verified? needs a bit more detail (0 characters, 40 expected).

Edit the description and this check re-runs on its own. The sections exist because they are the parts a reviewer cannot get from the diff: why the change is needed, how you know it works, and what breaks if it is wrong.

@palfrey

palfrey commented Aug 19, 2026

Copy link
Copy Markdown
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mridulmanohar This will need doing before we can merge this work

@mridulmanohar

Copy link
Copy Markdown
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mridulmanohar This will need doing before we can merge this work

thanks @palfrey - i've addressed this.

@amankrx
amankrx merged commit cbcdf64 into TraceMachina:main Aug 20, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants