Get rid of set_trace and replace with set -x (NOAA-EMC#4704)

This removes the set_trace bash function and replaces all calls to that
function with `set -x`

Author: CoryMartin-NOAA

dev/jobs/JGLOBAL_ATMOS_ANALYSIS_CALC_FV3JEDI

@@ -75,7 +75,7 @@ set +x
 if [[ ${err} -ne 0 ]]; then
     err_exit "${DATAROOT} does not exist, ABORT!"
 fi
-set_trace
+set -x
 if [[ ${KEEPDATA} == "NO" ]]; then
     rm -rf "${DATA}"
 fi

dev/jobs/JGLOBAL_ATM_ANALYSIS_FINALIZE

@@ -64,7 +64,7 @@ set +x
 if [[ ${err} -ne 0 ]]; then
     err_exit "${DATAROOT} does not exist, ABORT!"
 fi
-set_trace
+set -x
 if [[ "${KEEPDATA}" == "NO" ]]; then
     rm -rf "${DATA}"
 fi

dev/jobs/JGLOBAL_ATM_PREP_ANL_BIAS

@@ -122,7 +122,7 @@ fi
 if [[ ${err} -ne 0 ]]; then
     err_exit "FATAL ERROR executing ${EXSCRIPT}"
 fi
-set_trace
+set -x
 
 ##############################################
 # End JOB SPECIFIC work

dev/jobs/JGLOBAL_ENKF_ECEN_FV3JEDI

@@ -74,7 +74,7 @@ set +x
 if [[ ${err} -ne 0 ]]; then
     err_exit "${DATAROOT} does not exist, ABORT!"
 fi
-set_trace
+set -x
 if [[ "${KEEPDATA}" == "NO" ]]; then
     rm -rf "${DATA}"
 fi

dev/scripts/exgfs_atmos_awips_20km_1p0deg.sh

@@ -61,7 +61,7 @@ echo "#######################################"
 echo " Process GRIB AWIP GRIB2 PRODUCTS      "
 echo "#######################################"
 echo " "
-set_trace
+set -x
 
 # Set type of Interpolation for WGRIB2
 export opt1=' -set_grib_type same -new_grid_winds earth '

dev/ush/load_modules.sh

@@ -127,10 +127,7 @@ case "${MODULE_TYPE}" in
 
         module list
 
-        ftype=$(type -t set_trace || echo "")
-        if [[ "${ftype}" == "function" ]]; then
-            set_trace
-        elif [[ "${set_x}" == "YES" ]]; then
+        if [[ "${set_x}" == "YES" ]]; then
             set -x
         fi
 
@@ -221,11 +218,7 @@ case "${MODULE_TYPE}" in
 
         module list
 
-        # If this function exists in the environment, run it; else set -x if it was set on entering this script
-        ftype=$(type -t set_trace || echo "")
-        if [[ "${ftype}" == "function" ]]; then
-            set_trace
-        elif [[ "${set_x}" == "YES" ]]; then
+        if [[ "${set_x}" == "YES" ]]; then
             set -x
         fi
         ;;

ush/dataroot_com_path.sh

@@ -42,7 +42,7 @@ dataroot_com_path() {
     local new_com_path="${DATAROOT}/${relative_path}"
 
     echo "${new_com_path}"
-    set_trace
+    set -x
 }
 
 declare -xf dataroot_com_path

ush/jjob_shell_setup.sh

@@ -38,17 +38,16 @@ source "${USHglobal}/err_exit.sh"
 shopt -s nullglob # Allow null globs instead of treating * as literal
 
 ##############################################
-# Shell options and tracing
+# Shell options
 ##############################################
-source "${USHglobal}/set_trace.sh"
 export SHELLOPTS
 ##############################################
 # Create and enter the working directory
 ##############################################
 source "${USHglobal}/setup_data_dir.sh" "${DATA}"
 
 # Activate tracing
-set_trace
+set -x
 
 ##############################################
 # Exit trap: run postamble on exit to report elapsed time and clean up

ush/parsing_namelists_WW3.sh

@@ -16,7 +16,7 @@ WW3_namelists() {
     if [[ -f "${DATA}/ww3_points.list" ]]; then
         set +x
         echo "ww3_points.list copied (${PARMglobal}/wave/wave_${NET}.buoys)."
-        set_trace
+        set -x
     else
         echo "FATAL ERROR : ww3_points.list (${PARMglobal}/wave/wave_${NET}.buoys) NOT FOUND"
         exit 12