Fix #46 - Added new rule G-3145: Avoid using SELECT \* directly from a table or view.

Author: kibeha

docs/4-language-usage/3-dml-and-sql/1-general/g-3145.md

@@ -0,0 +1,48 @@
+# G-3145: Avoid using SELECT \* directly from a table or view.
+
+!!! warning "Major"
+    Efficiency, Maintainability, Reliability, Testability
+
+## Reason
+
+Use of SELECT \* when querying a table or view makes it impossible for the optimizer to take into account which columns will actually be used by the application, potentially leading to sub-optimal execution plans (for example full scanning the table where a full scan of an index might have sufficed.) Also SELECT \* possibly can break your code in the future in case of changes to the table structure (for example new or invisible columns.)
+
+Exceptions to the rule can be when querying an inline view (where the SELECT \* is just to avoid repeating same columns as inside the inline view), or when fetching into records defined as MYTABLE%ROWTYPE for the purpose of processing all columns of the record.
+
+## Example (bad)
+
+``` sql
+begin
+   for r_employee in (
+      select *
+        from employees
+   )
+   loop
+      employee_api.calculate_raise_by_seniority(
+         id_in       => r_employee.id
+        ,salary_in   => r_employee.salary
+        ,hiredate_in => r_employee.hiredate
+      );
+   end loop;
+end;
+/
+```
+
+## Example (good)
+
+``` sql
+begin
+   for r_employee in (
+      select id,salary,hiredate
+        from employees
+   )
+   loop
+      employee_api.calculate_raise_by_seniority(
+         id_in       => r_employee.id
+        ,salary_in   => r_employee.salary
+        ,hiredate_in => r_employee.hiredate
+      );
+   end loop;
+end;
+/
+```

docs/9-appendix/appendix.md

@@ -49,6 +49,7 @@ n/a | 3115 | Avoid self-assigning a column. | Minor |  |  | ✘ |  |  |  |
 27 | 3120 | Always use table aliases when your SQL statement involves more than one source. | Major |  |  | ✘ |  |  |  |  | 
 28 | 3130 | Try to use ANSI SQL-92 join syntax. | Minor |  |  | ✘ | ✘ |  |  |  | 
 29 | 3140 | Try to use anchored records as targets for your cursors.  | Major |  |  | ✘ |  | ✘ |  |  | 
+n/a | 3145 | Avoid using SELECT \* directly from a table or view. | Major |  | ✘ | ✘ |  | ✘ |  |  | ✘
 n/a | 3150 | Try to use identity columns for surrogate keys. | Minor |  |  | ✘ |  | ✘ |  |  | 
 n/a | 3160 | Avoid visible virtual columns. | Major |  |  | ✘ |  | ✘ |  |  | 
 n/a | 3170 | Always use DEFAULT ON NULL declarations to assign default values to table columns if you refuse to store NULL values. | Major |  |  |  |  | ✘ |  |  |