Skip to content

Refactor FluidTank to be safer in regards to multi-fluid usage #241

@BlayTheNinth

Description

@BlayTheNinth

Right now, several methods in FluidTank assume only a single fluid, and there's no reasonable way to fully implement a "composite" fluid tank with the current contract.

  • getFluid() assumes only a single fluid exists
  • getAmount() assumes only a single fluid exists
  • setAmount() assumes only a single fluid exists
  • getCapacity() assumes only a single fluid exists

In general our FluidTank interface is pretty dated, not matching the design of NeoForge's and Fabric's transfer APIs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking ChangeThis issue requires a breaking change to the API or ingame behaviorFeatureNew features or improvements to existing features

    Projects

    Status

    📧 On Hold

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions