Skip to content

Commit 22c3f03

Browse files
RunDevelopmentTylerJang27
RunDevelopment
authored and
TylerJang27
committed
Add support for i128 and u128 (rustwasm#4222)
1 parent 3a8da7c commit 22c3f03

File tree

17 files changed

+502
-8
lines changed

17 files changed

+502
-8
lines changed

‎CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# `wasm-bindgen` Change Log
22
--------------------------------------------------------------------------------
33

4+
## Unreleased
5+
6+
Unstable, local branch
7+
48
## [0.2.95](https://github.com/rustwasm/wasm-bindgen/compare/0.2.94...0.2.95)
59

610
Released 2024-10-10

‎crates/cli-support/src/descriptor.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ tys! {
1919
U32
2020
I64
2121
U64
22+
I128
23+
U128
2224
F32
2325
F64
2426
BOOLEAN
@@ -55,6 +57,8 @@ pub enum Descriptor {
5557
U32,
5658
I64,
5759
U64,
60+
I128,
61+
U128,
5862
F32,
5963
F64,
6064
Boolean,
@@ -132,11 +136,13 @@ impl Descriptor {
132136
I16 => Descriptor::I16,
133137
I32 => Descriptor::I32,
134138
I64 => Descriptor::I64,
139+
I128 => Descriptor::I128,
135140
U8 if clamped => Descriptor::ClampedU8,
136141
U8 => Descriptor::U8,
137142
U16 => Descriptor::U16,
138143
U32 => Descriptor::U32,
139144
U64 => Descriptor::U64,
145+
U128 => Descriptor::U128,
140146
F32 => Descriptor::F32,
141147
F64 => Descriptor::F64,
142148
BOOLEAN => Descriptor::Boolean,

‎crates/cli-support/src/js/binding.rs

Lines changed: 54 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,23 @@ fn instruction(
595595
)
596596
}
597597

598+
fn int128_to_int64x2(val: &str) -> (String, String) {
599+
// we don't need to perform any conversion here, because the JS
600+
// WebAssembly API will automatically convert the bigints to 64 bits
601+
// for us. This even allows us to ignore signedness.
602+
let low = val.to_owned();
603+
let high = format!("{val} >> BigInt(64)");
604+
(low, high)
605+
}
606+
fn int64x2_to_int128(low: String, high: String, signed: bool) -> String {
607+
let low = format!("BigInt.asUintN(64, {low})");
608+
if signed {
609+
format!("({low} | ({high} << BigInt(64)))")
610+
} else {
611+
format!("({low} | (BigInt.asUintN(64, {high}) << BigInt(64)))")
612+
}
613+
}
614+
598615
match instr {
599616
Instruction::ArgGet(n) => {
600617
let arg = js.arg(*n).to_string();
@@ -687,6 +704,36 @@ fn instruction(
687704
}
688705
}
689706

707+
Instruction::Int128ToWasm => {
708+
let val = js.pop();
709+
js.assert_bigint(&val);
710+
let (low, high) = int128_to_int64x2(&val);
711+
js.push(low);
712+
js.push(high);
713+
}
714+
Instruction::WasmToInt128 { signed } => {
715+
let high = js.pop();
716+
let low = js.pop();
717+
js.push(int64x2_to_int128(low, high, *signed));
718+
}
719+
720+
Instruction::OptionInt128ToWasm => {
721+
let val = js.pop();
722+
js.cx.expose_is_like_none();
723+
js.assert_optional_bigint(&val);
724+
let (low, high) = int128_to_int64x2(&val);
725+
js.push(format!("!isLikeNone({val})"));
726+
js.push(format!("isLikeNone({val}) ? BigInt(0) : {low}"));
727+
js.push(format!("isLikeNone({val}) ? BigInt(0) : {high}"));
728+
}
729+
Instruction::OptionWasmToInt128 { signed } => {
730+
let high = js.pop();
731+
let low = js.pop();
732+
let present = js.pop();
733+
let val = int64x2_to_int128(low, high, *signed);
734+
js.push(format!("{present} === 0 ? undefined : {val}"));
735+
}
736+
690737
Instruction::WasmToStringEnum { name } => {
691738
let index = js.pop();
692739
js.push(wasm_to_string_enum(name, &index))
@@ -917,6 +964,8 @@ fn instruction(
917964
js.push(format!(
918965
"isLikeNone({val}) ? {zero} : {val}",
919966
zero = if *ty == ValType::I64 {
967+
// We can't use bigint literals for now. See:
968+
// https://github.com/rustwasm/wasm-bindgen/issues/4246
920969
"BigInt(0)"
921970
} else {
922971
"0"
@@ -1429,7 +1478,11 @@ fn adapter2ts(ty: &AdapterType, dst: &mut String) {
14291478
| AdapterType::F32
14301479
| AdapterType::F64
14311480
| AdapterType::NonNull => dst.push_str("number"),
1432-
AdapterType::I64 | AdapterType::S64 | AdapterType::U64 => dst.push_str("bigint"),
1481+
AdapterType::I64
1482+
| AdapterType::S64
1483+
| AdapterType::U64
1484+
| AdapterType::S128
1485+
| AdapterType::U128 => dst.push_str("bigint"),
14331486
AdapterType::String => dst.push_str("string"),
14341487
AdapterType::Externref => dst.push_str("any"),
14351488
AdapterType::Bool => dst.push_str("boolean"),

‎crates/cli-support/src/wit/incoming.rs

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,20 @@ impl InstructionBuilder<'_, '_> {
9090
Descriptor::U32 => self.number(AdapterType::U32, WasmVT::I32),
9191
Descriptor::I64 => self.number(AdapterType::S64, WasmVT::I64),
9292
Descriptor::U64 => self.number(AdapterType::U64, WasmVT::I64),
93+
Descriptor::I128 => {
94+
self.instruction(
95+
&[AdapterType::S128],
96+
Instruction::Int128ToWasm,
97+
&[AdapterType::I64, AdapterType::I64],
98+
);
99+
}
100+
Descriptor::U128 => {
101+
self.instruction(
102+
&[AdapterType::U128],
103+
Instruction::Int128ToWasm,
104+
&[AdapterType::I64, AdapterType::I64],
105+
);
106+
}
93107
Descriptor::F32 => {
94108
self.get(AdapterType::F32);
95109
self.output.push(AdapterType::F32);
@@ -285,6 +299,20 @@ impl InstructionBuilder<'_, '_> {
285299
Descriptor::F32 => self.in_option_native(ValType::F32),
286300
Descriptor::F64 => self.in_option_native(ValType::F64),
287301
Descriptor::I64 | Descriptor::U64 => self.in_option_native(ValType::I64),
302+
Descriptor::I128 => {
303+
self.instruction(
304+
&[AdapterType::S128.option()],
305+
Instruction::OptionInt128ToWasm,
306+
&[AdapterType::I32, AdapterType::I64, AdapterType::I64],
307+
);
308+
}
309+
Descriptor::U128 => {
310+
self.instruction(
311+
&[AdapterType::U128.option()],
312+
Instruction::OptionInt128ToWasm,
313+
&[AdapterType::I32, AdapterType::I64, AdapterType::I64],
314+
);
315+
}
288316
Descriptor::Boolean => {
289317
self.instruction(
290318
&[AdapterType::Bool.option()],

‎crates/cli-support/src/wit/outgoing.rs

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,20 @@ impl InstructionBuilder<'_, '_> {
6565
Descriptor::U32 => self.outgoing_i32(AdapterType::U32),
6666
Descriptor::I64 => self.outgoing_i64(AdapterType::I64),
6767
Descriptor::U64 => self.outgoing_i64(AdapterType::U64),
68+
Descriptor::I128 => {
69+
self.instruction(
70+
&[AdapterType::I64, AdapterType::I64],
71+
Instruction::WasmToInt128 { signed: true },
72+
&[AdapterType::S128],
73+
);
74+
}
75+
Descriptor::U128 => {
76+
self.instruction(
77+
&[AdapterType::I64, AdapterType::I64],
78+
Instruction::WasmToInt128 { signed: false },
79+
&[AdapterType::U128],
80+
);
81+
}
6882
Descriptor::F32 => {
6983
self.get(AdapterType::F32);
7084
self.output.push(AdapterType::F32);
@@ -267,6 +281,20 @@ impl InstructionBuilder<'_, '_> {
267281
Descriptor::U64 => self.option_native(false, ValType::I64),
268282
Descriptor::F32 => self.option_native(true, ValType::F32),
269283
Descriptor::F64 => self.option_native(true, ValType::F64),
284+
Descriptor::I128 => {
285+
self.instruction(
286+
&[AdapterType::I32, AdapterType::I64, AdapterType::I64],
287+
Instruction::OptionWasmToInt128 { signed: true },
288+
&[AdapterType::S128.option()],
289+
);
290+
}
291+
Descriptor::U128 => {
292+
self.instruction(
293+
&[AdapterType::I32, AdapterType::I64, AdapterType::I64],
294+
Instruction::OptionWasmToInt128 { signed: false },
295+
&[AdapterType::U128.option()],
296+
);
297+
}
270298
Descriptor::Boolean => {
271299
self.instruction(
272300
&[AdapterType::I32],
@@ -360,6 +388,8 @@ impl InstructionBuilder<'_, '_> {
360388
| Descriptor::F64
361389
| Descriptor::I64
362390
| Descriptor::U64
391+
| Descriptor::I128
392+
| Descriptor::U128
363393
| Descriptor::Boolean
364394
| Descriptor::Char
365395
| Descriptor::Enum { .. }

‎crates/cli-support/src/wit/standard.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,12 @@ pub enum AdapterType {
7171
S16,
7272
S32,
7373
S64,
74+
S128,
7475
U8,
7576
U16,
7677
U32,
7778
U64,
79+
U128,
7880
F32,
7981
F64,
8082
String,
@@ -141,6 +143,18 @@ pub enum Instruction {
141143
output: AdapterType,
142144
},
143145

146+
/// Pops a 128-bit integer and pushes 2 Wasm 64-bit ints.
147+
Int128ToWasm,
148+
/// Pops 2 Wasm 64-bit ints and pushes a 128-bit integer.
149+
WasmToInt128 {
150+
signed: bool,
151+
},
152+
153+
OptionInt128ToWasm,
154+
OptionWasmToInt128 {
155+
signed: bool,
156+
},
157+
144158
/// Pops a Wasm `i32` and pushes the enum variant as a string
145159
WasmToStringEnum {
146160
name: String,

‎crates/cli/tests/reference/int128.d.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/* tslint:disable */
2+
/* eslint-disable */
3+
export function echo_i128(a: bigint): bigint;
4+
export function echo_u128(a: bigint): bigint;
5+
export function echo_option_i128(a?: bigint): bigint | undefined;
6+
export function echo_option_u128(a?: bigint): bigint | undefined;
7+
export function throw_i128(): bigint;

‎crates/cli/tests/reference/int128.js

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
let wasm;
2+
export function __wbg_set_wasm(val) {
3+
wasm = val;
4+
}
5+
6+
/**
7+
* @param {bigint} a
8+
* @returns {bigint}
9+
*/
10+
export function echo_i128(a) {
11+
const ret = wasm.echo_i128(a, a >> BigInt(64));
12+
return (BigInt.asUintN(64, ret[0]) | (ret[1] << BigInt(64)));
13+
}
14+
15+
/**
16+
* @param {bigint} a
17+
* @returns {bigint}
18+
*/
19+
export function echo_u128(a) {
20+
const ret = wasm.echo_u128(a, a >> BigInt(64));
21+
return (BigInt.asUintN(64, ret[0]) | (BigInt.asUintN(64, ret[1]) << BigInt(64)));
22+
}
23+
24+
function isLikeNone(x) {
25+
return x === undefined || x === null;
26+
}
27+
/**
28+
* @param {bigint | undefined} [a]
29+
* @returns {bigint | undefined}
30+
*/
31+
export function echo_option_i128(a) {
32+
const ret = wasm.echo_option_i128(!isLikeNone(a), isLikeNone(a) ? BigInt(0) : a, isLikeNone(a) ? BigInt(0) : a >> BigInt(64));
33+
return ret[0] === 0 ? undefined : (BigInt.asUintN(64, ret[1]) | (ret[2] << BigInt(64)));
34+
}
35+
36+
/**
37+
* @param {bigint | undefined} [a]
38+
* @returns {bigint | undefined}
39+
*/
40+
export function echo_option_u128(a) {
41+
const ret = wasm.echo_option_u128(!isLikeNone(a), isLikeNone(a) ? BigInt(0) : a, isLikeNone(a) ? BigInt(0) : a >> BigInt(64));
42+
return ret[0] === 0 ? undefined : (BigInt.asUintN(64, ret[1]) | (BigInt.asUintN(64, ret[2]) << BigInt(64)));
43+
}
44+
45+
const heap = new Array(128).fill(undefined);
46+
47+
heap.push(undefined, null, true, false);
48+
49+
function getObject(idx) { return heap[idx]; }
50+
51+
let heap_next = heap.length;
52+
53+
function dropObject(idx) {
54+
if (idx < 132) return;
55+
heap[idx] = heap_next;
56+
heap_next = idx;
57+
}
58+
59+
function takeObject(idx) {
60+
const ret = getObject(idx);
61+
dropObject(idx);
62+
return ret;
63+
}
64+
/**
65+
* @returns {bigint}
66+
*/
67+
export function throw_i128() {
68+
const ret = wasm.throw_i128();
69+
if (ret[3]) {
70+
throw takeObject(ret[2]);
71+
}
72+
return (BigInt.asUintN(64, ret[0]) | (ret[1] << BigInt(64)));
73+
}
74+

‎crates/cli/tests/reference/int128.rs

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
use wasm_bindgen::prelude::*;
2+
3+
#[wasm_bindgen]
4+
pub fn echo_i128(a: i128) -> i128 {
5+
a
6+
}
7+
#[wasm_bindgen]
8+
pub fn echo_u128(a: u128) -> u128 {
9+
a
10+
}
11+
12+
#[wasm_bindgen]
13+
pub fn echo_option_i128(a: Option<i128>) -> Option<i128> {
14+
a
15+
}
16+
#[wasm_bindgen]
17+
pub fn echo_option_u128(a: Option<u128>) -> Option<u128> {
18+
a
19+
}
20+
21+
#[wasm_bindgen]
22+
pub fn throw_i128() -> Result<i128, JsError> {
23+
Ok(0_i128)
24+
}
25+
// #[wasm_bindgen]
26+
// pub fn throw_option_i128() -> Result<Option<i128>, JsError> {
27+
// Ok(None)
28+
// }

‎crates/cli/tests/reference/int128.wat

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
(module $reference_test.wasm
2+
(type (;0;) (func (result i64 i64 i32 i32)))
3+
(type (;1;) (func (param i32 i64 i64) (result i32 i64 i64)))
4+
(type (;2;) (func (param i64 i64) (result i64 i64)))
5+
(func $"echo_option_i128 multivalue shim" (;0;) (type 1) (param i32 i64 i64) (result i32 i64 i64))
6+
(func $"echo_option_u128 multivalue shim" (;1;) (type 1) (param i32 i64 i64) (result i32 i64 i64))
7+
(func $"throw_i128 multivalue shim" (;2;) (type 0) (result i64 i64 i32 i32))
8+
(func $"echo_i128 multivalue shim" (;3;) (type 2) (param i64 i64) (result i64 i64))
9+
(func $"echo_u128 multivalue shim" (;4;) (type 2) (param i64 i64) (result i64 i64))
10+
(memory (;0;) 17)
11+
(export "memory" (memory 0))
12+
(export "echo_i128" (func $"echo_i128 multivalue shim"))
13+
(export "echo_u128" (func $"echo_u128 multivalue shim"))
14+
(export "echo_option_i128" (func $"echo_option_i128 multivalue shim"))
15+
(export "echo_option_u128" (func $"echo_option_u128 multivalue shim"))
16+
(export "throw_i128" (func $"throw_i128 multivalue shim"))
17+
(@custom "target_features" (after code) "\04+\0amultivalue+\0fmutable-globals+\0freference-types+\08sign-ext")
18+
)
19+

‎crates/macro/ui-tests/missing-catch.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ error[E0277]: the trait bound `Result<wasm_bindgen::JsValue, wasm_bindgen::JsVal
1212
i16
1313
i32
1414
i64
15-
usize
15+
i128
1616
and $N others

‎crates/macro/ui-tests/traits-not-implemented.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ error[E0277]: the trait bound `A: IntoWasmAbi` is not satisfied
1212
i16
1313
i32
1414
i64
15-
usize
15+
i128
1616
and $N others
1717
= note: this error originates in the attribute macro `wasm_bindgen` (in Nightly builds, run with -Z macro-backtrace for more info)

0 commit comments

Comments
 (0)