Skip to content

Commit f06ff68

Browse files
reinholdkjohnnyreilly
reinholdk
authored and
johnnyreilly
committed
fix: no errors reported if flagged with @ts-check (#1008)
1 parent ae0698d commit f06ff68

File tree

9 files changed

+191
-1
lines changed

9 files changed

+191
-1
lines changed

‎src/after-compile.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ function provideErrorsToWebpack(
186186
} = instance;
187187

188188
const filePathRegex =
189-
compilerOptions.checkJs === true
189+
compilerOptions.allowJs === true
190190
? constants.dtsTsTsxJsJsxRegex
191191
: constants.dtsTsTsxRegex;
192192

‎test/comparison-tests/allowJs-ts-check/expectedOutput-3.6/bundle.js‎

Lines changed: 125 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
1+
/******/ (function(modules) { // webpackBootstrap
2+
/******/ // The module cache
3+
/******/ var installedModules = {};
4+
/******/
5+
/******/ // The require function
6+
/******/ function __webpack_require__(moduleId) {
7+
/******/
8+
/******/ // Check if module is in cache
9+
/******/ if(installedModules[moduleId]) {
10+
/******/ return installedModules[moduleId].exports;
11+
/******/ }
12+
/******/ // Create a new module (and put it into the cache)
13+
/******/ var module = installedModules[moduleId] = {
14+
/******/ i: moduleId,
15+
/******/ l: false,
16+
/******/ exports: {}
17+
/******/ };
18+
/******/
19+
/******/ // Execute the module function
20+
/******/ modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
21+
/******/
22+
/******/ // Flag the module as loaded
23+
/******/ module.l = true;
24+
/******/
25+
/******/ // Return the exports of the module
26+
/******/ return module.exports;
27+
/******/ }
28+
/******/
29+
/******/
30+
/******/ // expose the modules object (__webpack_modules__)
31+
/******/ __webpack_require__.m = modules;
32+
/******/
33+
/******/ // expose the module cache
34+
/******/ __webpack_require__.c = installedModules;
35+
/******/
36+
/******/ // define getter function for harmony exports
37+
/******/ __webpack_require__.d = function(exports, name, getter) {
38+
/******/ if(!__webpack_require__.o(exports, name)) {
39+
/******/ Object.defineProperty(exports, name, { enumerable: true, get: getter });
40+
/******/ }
41+
/******/ };
42+
/******/
43+
/******/ // define __esModule on exports
44+
/******/ __webpack_require__.r = function(exports) {
45+
/******/ if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
46+
/******/ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
47+
/******/ }
48+
/******/ Object.defineProperty(exports, '__esModule', { value: true });
49+
/******/ };
50+
/******/
51+
/******/ // create a fake namespace object
52+
/******/ // mode & 1: value is a module id, require it
53+
/******/ // mode & 2: merge all properties of value into the ns
54+
/******/ // mode & 4: return value when already ns object
55+
/******/ // mode & 8|1: behave like require
56+
/******/ __webpack_require__.t = function(value, mode) {
57+
/******/ if(mode & 1) value = __webpack_require__(value);
58+
/******/ if(mode & 8) return value;
59+
/******/ if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;
60+
/******/ var ns = Object.create(null);
61+
/******/ __webpack_require__.r(ns);
62+
/******/ Object.defineProperty(ns, 'default', { enumerable: true, value: value });
63+
/******/ if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));
64+
/******/ return ns;
65+
/******/ };
66+
/******/
67+
/******/ // getDefaultExport function for compatibility with non-harmony modules
68+
/******/ __webpack_require__.n = function(module) {
69+
/******/ var getter = module && module.__esModule ?
70+
/******/ function getDefault() { return module['default']; } :
71+
/******/ function getModuleExports() { return module; };
72+
/******/ __webpack_require__.d(getter, 'a', getter);
73+
/******/ return getter;
74+
/******/ };
75+
/******/
76+
/******/ // Object.prototype.hasOwnProperty.call
77+
/******/ __webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
78+
/******/
79+
/******/ // __webpack_public_path__
80+
/******/ __webpack_require__.p = "";
81+
/******/
82+
/******/
83+
/******/ // Load entry module and return exports
84+
/******/ return __webpack_require__(__webpack_require__.s = "./src/index.js");
85+
/******/ })
86+
/************************************************************************/
87+
/******/ ({
88+
89+
/***/ "./src/error1.js":
90+
/*!***********************!*\
91+
!*** ./src/error1.js ***!
92+
\***********************/
93+
/*! no static exports found */
94+
/***/ (function(module, exports, __webpack_require__) {
95+
96+
"use strict";
97+
eval("\nObject.defineProperty(exports, \"__esModule\", { value: true });\nvar Class1 = /** @class */ (function () {\n function Class1() {\n }\n Class1.prototype.foo = function () {\n this.bar;\n };\n return Class1;\n}());\nexports.Class1 = Class1;\n\n\n//# sourceURL=webpack:///./src/error1.js?");
98+
99+
/***/ }),
100+
101+
/***/ "./src/error2.js":
102+
/*!***********************!*\
103+
!*** ./src/error2.js ***!
104+
\***********************/
105+
/*! no static exports found */
106+
/***/ (function(module, exports, __webpack_require__) {
107+
108+
"use strict";
109+
eval("\nObject.defineProperty(exports, \"__esModule\", { value: true });\n// @ts-check\nvar Class2 = /** @class */ (function () {\n function Class2() {\n }\n Class2.prototype.foo = function () {\n this.bar;\n };\n return Class2;\n}());\nexports.Class2 = Class2;\n\n\n//# sourceURL=webpack:///./src/error2.js?");
110+
111+
/***/ }),
112+
113+
/***/ "./src/index.js":
114+
/*!**********************!*\
115+
!*** ./src/index.js ***!
116+
\**********************/
117+
/*! no static exports found */
118+
/***/ (function(module, exports, __webpack_require__) {
119+
120+
"use strict";
121+
eval("\nObject.defineProperty(exports, \"__esModule\", { value: true });\nvar error1_1 = __webpack_require__(/*! ./error1 */ \"./src/error1.js\");\nvar error2_1 = __webpack_require__(/*! ./error2 */ \"./src/error2.js\");\nnew error1_1.Class1().foo();\nnew error2_1.Class2().foo();\n\n\n//# sourceURL=webpack:///./src/index.js?");
122+
123+
/***/ })
124+
125+
/******/ });

‎test/comparison-tests/allowJs-ts-check/expectedOutput-3.6/output.transpiled.txt‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Asset Size Chunks Chunk Names
2+
bundle.js 5.15 KiB main [emitted] main
3+
Entrypoint main = bundle.js
4+
[./src/error1.js] 265 bytes {main} [built]
5+
[./src/error2.js] 278 bytes {main} [built]
6+
[./src/index.js] 207 bytes {main} [built]

‎test/comparison-tests/allowJs-ts-check/expectedOutput-3.6/output.txt‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
Asset Size Chunks Chunk Names
2+
bundle.js 5.15 KiB main [emitted] main
3+
Entrypoint main = bundle.js
4+
[./src/error1.js] 265 bytes {main} [built]
5+
[./src/error2.js] 278 bytes {main} [built] [1 error]
6+
[./src/index.js] 207 bytes {main} [built]
7+
8+
ERROR in src\error2.js
9+
./src/error2.js
10+
[tsl] ERROR in src\error2.js(4,10)
11+
 TS2339: Property 'bar' does not exist on type 'Class2'.

‎test/comparison-tests/allowJs-ts-check/src/error1.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
export class Class1 {
2+
foo() {
3+
this.bar
4+
}
5+
}

‎test/comparison-tests/allowJs-ts-check/src/error2.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// @ts-check
2+
export class Class2 {
3+
foo() {
4+
this.bar
5+
}
6+
}

‎test/comparison-tests/allowJs-ts-check/src/index.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { Class1 } from './error1';
2+
import { Class2 } from './error2';
3+
4+
new Class1().foo();
5+
new Class2().foo();

‎test/comparison-tests/allowJs-ts-check/tsconfig.json‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"compilerOptions": {
3+
"target": "es5",
4+
"module": "commonjs",
5+
"emitBOM": true,
6+
"outDir": "node",
7+
"allowJs": true
8+
},
9+
"include": [
10+
"src"
11+
]
12+
}

‎test/comparison-tests/allowJs-ts-check/webpack.config.js‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
module.exports = {
2+
mode: 'development',
3+
entry: './src/index.js',
4+
output: {
5+
filename: 'bundle.js'
6+
},
7+
resolve: {
8+
extensions: ['.ts', '.js']
9+
},
10+
module: {
11+
rules: [
12+
{
13+
test: /\.(js)$/,
14+
loader: 'ts-loader'
15+
}
16+
]
17+
}
18+
}
19+
20+

0 commit comments

Comments
 (0)