Merge pull request #61 from Typeform/WEB-4636/add-curly-and-prefer-destructuring

Author: georgegillams

index.js

@@ -23,6 +23,8 @@ module.exports = {
   },
   rules: {
     'no-var': 'warn',
+    'curly': 'warn',
+    'prefer-destructuring': 'warn',
     '@typescript-eslint/no-extra-semi': 'off',
     'import/order': [
       'warn',

index.test.js

@@ -36,6 +36,28 @@ describe('eslint config', () => {
     expect(output.includes('"errorCount":0')).toBeTruthy()
     expect(output.includes('"warningCount":1')).toBeTruthy()
   })
+
+  it('should warn if braces are not used', () => {
+    const output = child_process
+      .execSync('yarn eslint -f "json" --no-ignore test-cases/warn-curly.js')
+      .toString()
+
+    expect(output.includes('"ruleId":"curly"')).toBeTruthy()
+    expect(output.includes('"errorCount":0')).toBeTruthy()
+    expect(output.includes('"warningCount":2')).toBeTruthy()
+  })
+
+  it('should warn if destructuring is not used', () => {
+    const output = child_process
+      .execSync(
+        'yarn eslint -f "json" --no-ignore test-cases/warn-prefer-destructuring.js'
+      )
+      .toString()
+
+    expect(output.includes('"ruleId":"prefer-destructuring"')).toBeTruthy()
+    expect(output.includes('"errorCount":0')).toBeTruthy()
+    expect(output.includes('"warningCount":1')).toBeTruthy()
+  })
   // #endregion
 
   // #region Fail

test-cases/pass.js

@@ -1,3 +1,8 @@
 const myConstant = 34
 let myVariable = myConstant + 5
+const data = { a: 5, b: 1 }
+if (true) {
+  const { a } = data
+  myVariable += a + data.b
+}
 return myVariable

test-cases/warn-curly.js

@@ -0,0 +1,7 @@
+let condition1 = true
+let condition2 = false
+let myVariable = 34
+if (condition1) myVariable += 5
+if (condition2)
+  myVariable = myVariable * myVariable + 5 - myVariable - 2 * myVariable
+return myVariable

test-cases/warn-prefer-destructuring.js

@@ -0,0 +1,4 @@
+const data = { a: 5, b: 1 }
+const a = data.a
+const myVariable = 34 + a + data.b
+return myVariable