Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] karatemplater doesn't compute the right syllable styles #311

Closed
red5h4d0w opened this issue Feb 2, 2025 · 4 comments
Closed

[Bug] karatemplater doesn't compute the right syllable styles #311

red5h4d0w opened this issue Feb 2, 2025 · 4 comments

Comments

@red5h4d0w
Copy link

When Applying Karaoke Template, the computed syl.style does not match the intended style when a \rStyle Name tag was used.

Example:

Using the template syl line {\an5\pos(!line.left+syl.center!,!$middle!)\k!$start/10!\r!syl.style.name!\k$skdur}, the computed style should be enforced on the generated lines.

Before applying the the karaoke template:

Image

After application:

Image

Link to the example file I made to highlight the issue: example file.ass

@arch1t3cht
Copy link
Member

arch1t3cht commented Feb 2, 2025

I'm not sure if the templater really should do that. I can see the use case, of course, but this feels out of bounds for the templater (which only really splits lines into syllables and doesn't have special handling for any other tags either). At the very least, this is not a bug, at most a feature request.

If you wanted to, you could make your template do this using inline fx, i.e. replace your \rFoo tags by \-Foo and put something like {\r!syl.inline_fx!} at the start of your template.

@red5h4d0w
Copy link
Author

Okay I was under the impression that it was intended to compute syllable style, since there is no use for syl.style when it will always be the same as line.style (from what I understand).

I'll open a new ticket as a feature request.

@FichteFoll
Copy link
Contributor

syl.X is mostly identical to line.X because it is cloned from it and can be used as the main entry point for any syl template. Only the syllable-specific properties are updated for individual syl iteration.

@red5h4d0w
Copy link
Author

syl.X is mostly identical to line.X because it is cloned from it and can be used as the main entry point for any syl template. Only the syllable-specific properties are updated for individual syl iteration.

My point was that style could be syllable specific if reset style tags were used and this is what I adressed in PR #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants