[ui5-builder][INTERNAL] manifestCreator: log verbose for apf (#501)

library /sap/apf has both a Component.js and a
.library file. This can't be solved due to
backward compatibility. Therefore the log level
was decreased from error to verbose.

Author: tobiasso85

packages/builder/lib/processors/manifestCreator.js

@@ -164,6 +164,9 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 				const relativePath = comp.getPath().slice(prefix.length);
 				if ( relativePath.lastIndexOf("/") >= 0 ) {
 					result.push( relativePath.slice(0, relativePath.lastIndexOf("/")) );
+				} else if ( prefix === "/resources/sap/apf/" ) {
+					log.verbose("Package %s contains both '*.library' and 'Component.js'. " +
+						"This is a known issue but can't be solved due to backward compatibility.", comp.getPath());
 				} else if ( prefix !== "/resources/sap/ui/core/" ) {
 					log.error("Package %s contains both '*.library' and 'Component.js'. " +
 						"This is not supported by manifests, therefore the component won't be " +

packages/builder/test/lib/processors/manifestCreator.js

@@ -0,0 +1,116 @@
+const test = require("ava");
+const sinon = require("sinon");
+const mock = require("mock-require");
+
+const manifestCreator = require("../../../lib/processors/manifestCreator");
+
+const libraryContent = `<?xml version="1.0" encoding="UTF-8" ?>
+<library xmlns="http://www.sap.com/sap.ui.library.xsd" >
+	<name>library.e</name>
+	<vendor>SAP SE</vendor>
+	<copyright>my copyright</copyright>
+	<version>1.0.0</version>   
+	<documentation>Library E</documentation>
+	
+	<dependencies>
+	    <dependency>
+	      <libraryName>sap.ui.core</libraryName>
+	    </dependency>
+	</dependencies>
+</library>`;
+
+const expectedManifestContent = `{
+  "_version": "1.9.0",
+  "sap.app": {
+    "id": "library.e",
+    "type": "library",
+    "embeds": [],
+    "applicationVersion": {
+      "version": "1.0.0"
+    },
+    "title": "Library E",
+    "description": "Library E",
+    "resources": "resources.json",
+    "offline": true
+  },
+  "sap.ui": {
+    "technology": "UI5",
+    "supportedThemes": []
+  },
+  "sap.ui5": {
+    "dependencies": {
+      "libs": {
+        "sap.ui.core": {}
+      }
+    },
+    "library": {
+      "i18n": false
+    }
+  }
+}`;
+
+test.afterEach.always((t) => {
+	mock.stopAll();
+	sinon.restore();
+});
+
+test("default manifest creation", async (t) => {
+	const libraryResource = {
+		getPath: () => {
+			return "/resources/sap/ui/mine/.library";
+		},
+		getString: async () => {
+			return libraryContent;
+		},
+		_project: {
+			dependencies: [{
+				metadata: {
+					name: "sap.ui.core"
+				}
+			}]
+		}
+	};
+
+	const result = await manifestCreator({libraryResource, resources: [], options: {}});
+	t.is(await result.getString(), expectedManifestContent, "Correct result returned");
+});
+
+test.serial("manifest creation for sap/apf", async (t) => {
+	const logger = require("@ui5/logger");
+	const verboseLogStub = sinon.stub();
+	const myLoggerInstance = {
+		verbose: verboseLogStub
+	};
+	sinon.stub(logger, "getLogger").returns(myLoggerInstance);
+	const manifestCreatorWithStub = mock.reRequire("../../../lib/processors/manifestCreator");
+
+
+	const libraryResource = {
+		getPath: () => {
+			return "/resources/sap/apf/.library";
+		},
+		getString: async () => {
+			return libraryContent;
+		},
+		_project: {
+			dependencies: [{
+				metadata: {
+					name: "sap.ui.core"
+				}
+			}]
+		}
+	};
+
+	const componentResource = {
+		getPath: () => {
+			return "/resources/sap/apf/Component.js";
+		}
+	};
+
+	const result = await manifestCreatorWithStub({libraryResource, resources: [componentResource], options: {}});
+	t.is(await result.getString(), expectedManifestContent, "Correct result returned");
+
+	t.is(verboseLogStub.callCount, 8);
+	t.is(verboseLogStub.firstCall.args[0], "Package %s contains both '*.library' and 'Component.js'. This is a known issue but can't be solved due to backward compatibility.");
+	t.is(verboseLogStub.firstCall.args[1], "/resources/sap/apf/Component.js");
+});