Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] httpHeaders support #92

Open
jutley opened this issue Nov 15, 2024 · 1 comment
Open

[FEATURE REQ] httpHeaders support #92

jutley opened this issue Nov 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jutley
Copy link

jutley commented Nov 15, 2024

Is your feature request related to a problem? Please describe.

link-check supports the field httpHeaders, which can allow headers to be added to requests that match certain URLs. linkspector has a bit of code for this field, but the structure is different (only supports a single URL, for example), and the code isn't used anywhere.

This feature is important for being able to access documentation which requires bearer tokens, or other authentication.

Describe the solution you'd like

I'd like support for this field, as was supported for link-check.

Describe alternatives you've considered

I'll keep using link-check until this is supported. I was looking at this project because the link-check GH action seems to be replaced with one that uses this project.

Additional context

Nope

@jutley jutley added the enhancement New feature or request label Nov 15, 2024
@gaurav-nelson
Copy link
Contributor

@jutley Thanks for creating this issue. I've created the header-support branch to fix this issue. Can you test this for your use case?

git clone -b header-support git@github.com:UmbrellaDocs/linkspector.git
cd linkspector
npm i
node index.js check -c <configfile>

PS: https://github.com/UmbrellaDocs/linkspector/tree/header-support?tab=readme-ov-file#http-headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants