Address PR feedback: remove banner Activity-context requirement

BannerView accepts a plain Context since Unity Ads SDK 4.16.2, so drop
the Activity checks in collectSignals and the banner load path and pass
the context through directly. Also tighten the RoutingTokenListener
Javadoc to the implemented behavior.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: vishaldhiman-unity

ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityBannerViewFactory.java

@@ -1,14 +1,14 @@
 package com.google.ads.mediation.unity;
 
-import android.app.Activity;
+import android.content.Context;
 import com.unity3d.services.banners.BannerView;
 import com.unity3d.services.banners.UnityBannerSize;
 
 /** A factory to create UnityAds {@link BannerView} for Banner Ads */
 class UnityBannerViewFactory {
   UnityBannerViewWrapper createBannerView(
-      Activity activity, String placementId, UnityBannerSize bannerSize) {
-    BannerView bannerView = new BannerView(activity, placementId, bannerSize);
+      Context context, String placementId, UnityBannerSize bannerSize) {
+    BannerView bannerView = new BannerView(context, placementId, bannerSize);
     return new UnityBannerViewWrapper(bannerView);
   }
 }

ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationAdapter.java

@@ -17,7 +17,6 @@
 import static com.google.ads.mediation.unity.UnityAdsAdapterUtils.createSDKError;
 import static com.google.ads.mediation.unity.UnityAdsAdapterUtils.getAdFormat;
 
-import android.app.Activity;
 import android.content.Context;
 import android.os.Bundle;
 import android.text.TextUtils;
@@ -211,18 +210,6 @@ public void collectSignals(
     AdFormat adFormat = getAdFormat(rtbSignalData);
     com.unity3d.ads.AdFormat unityAdFormat = null;
 
-    // For banner ad format, Unity Ads SDK requires an activity context to load the banner ad. So,
-    // fail here so that Unity bidder will not bid if the ad request was made with a non-activity
-    // context.
-    if (adFormat == AdFormat.BANNER && !(rtbSignalData.getContext() instanceof Activity)) {
-      signalCallbacks.onFailure(
-          new AdError(
-              ERROR_CONTEXT_NOT_ACTIVITY,
-              "Unity Ads RTB Banner ads require activity context",
-              ADAPTER_ERROR_DOMAIN));
-      return;
-    }
-
     if (adFormat == AdFormat.BANNER) {
       unityAdFormat = com.unity3d.ads.AdFormat.BANNER;
     } else if (adFormat == AdFormat.REWARDED || adFormat == AdFormat.REWARDED_INTERSTITIAL) {
@@ -242,7 +229,7 @@ public void collectSignals(
     }
   }
 
-  /** Routes a null/empty token or a token failure to onFailure, invoking signalCallbacks once. */
+  /** Routes a null or empty token to onFailure and a non-empty token to onSuccess. */
   @VisibleForTesting
   static final class RoutingTokenListener implements IUnityAdsTokenListener {
     private final SignalCallbacks signalCallbacks;

ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationBannerAd.java

@@ -19,10 +19,8 @@
 import static com.google.ads.mediation.unity.UnityAdsAdapterUtils.getMediationErrorCode;
 import static com.google.ads.mediation.unity.UnityMediationAdapter.ADAPTER_ERROR_DOMAIN;
 import static com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_MSG_MISSING_PARAMETERS;
-import static com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_MSG_NON_ACTIVITY;
 import static com.google.ads.mediation.unity.UnityMediationAdapter.KEY_WATERMARK;
 
-import android.app.Activity;
 import android.content.Context;
 import android.os.Bundle;
 import android.text.TextUtils;
@@ -176,18 +174,6 @@ public void loadAd(
       return;
     }
 
-    if (!(context instanceof Activity)) {
-      AdError adError =
-          new AdError(
-              UnityMediationAdapter.ERROR_CONTEXT_NOT_ACTIVITY,
-              ERROR_MSG_NON_ACTIVITY,
-              ADAPTER_ERROR_DOMAIN);
-      Log.w(UnityMediationAdapter.TAG, adError.toString());
-      mediationBannerAdLoadCallback.onFailure(adError);
-      return;
-    }
-    final Activity activity = (Activity) context;
-
     final String adMarkup = mediationBannerAdConfiguration.getBidResponse();
 
     // It is RTB if adMarkup is not empty.
@@ -224,7 +210,7 @@ public void onInitializationComplete() {
             if (unityBannerViewWrapper == null) {
               unityBannerViewWrapper =
                   unityBannerViewFactory.createBannerView(
-                      activity, bannerPlacementId, unityBannerSize);
+                      context, bannerPlacementId, unityBannerSize);
             }
 
             unityBannerViewWrapper.setListener(UnityMediationBannerAd.this);

ThirdPartyAdapters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityMediationAdapterTest.kt

@@ -12,11 +12,9 @@ import com.google.ads.mediation.unity.UnityInitializer.KEY_ADAPTER_VERSION
 import com.google.ads.mediation.unity.UnityInterstitialAd.ERROR_MSG_INTERSTITIAL_INITIALIZATION_FAILED
 import com.google.ads.mediation.unity.UnityMediationAdapter.ADAPTER_ERROR_DOMAIN
 import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_BANNER_SIZE_MISMATCH
-import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_CONTEXT_NOT_ACTIVITY
 import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_INVALID_SERVER_PARAMETERS
 import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_MSG_INITIALIZATION_FAILURE
 import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_MSG_MISSING_PARAMETERS
-import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_MSG_NON_ACTIVITY
 import com.google.ads.mediation.unity.UnityMediationAdapter.ERROR_TOKEN_GENERATION_FAILED
 import com.google.ads.mediation.unity.UnityMediationAdapter.SDK_ERROR_DOMAIN
 import com.google.ads.mediation.unity.UnityMediationBannerAd.ERROR_MSG_INITIALIZATION_FAILED_FOR_GAME_ID
@@ -219,7 +217,13 @@ class UnityMediationAdapterTest {
   }
 
   @Test
-  fun collectSignals_forBannerFormatAndNonActivityContext_fails() {
+  fun collectSignals_forBannerFormatAndNonActivityContext_invokesSignalCallbacks() {
+    whenever(unityAdsWrapper.getToken(any(), any())) doAnswer
+      { invocation ->
+        val callback = invocation.arguments[1] as IUnityAdsTokenListener
+        callback.onUnityAdsTokenReady(TEST_TOKEN)
+      }
+
     val rtbSignalData =
       RtbSignalData(
         nonActivityContext,
@@ -230,12 +234,7 @@ class UnityMediationAdapterTest {
 
     unityMediationAdapter.collectSignals(rtbSignalData, signalCallbacks)
 
-    val adErrorCaptor = argumentCaptor<AdError>()
-    verify(signalCallbacks).onFailure(adErrorCaptor.capture())
-    val adError = adErrorCaptor.firstValue
-    assertThat(adError.code).isEqualTo(ERROR_CONTEXT_NOT_ACTIVITY)
-    assertThat(adError.domain).isEqualTo(ADAPTER_ERROR_DOMAIN)
-    verifyNoMoreInteractions(signalCallbacks)
+    verify(signalCallbacks).onSuccess(TEST_TOKEN)
   }
 
   @Test
@@ -500,20 +499,17 @@ class UnityMediationAdapterTest {
   }
 
   @Test
-  fun loadBannerAd_withNonActivityContext_failsWithAdError() {
-    mediationBannerAdConfiguration = initializeBannerAd(ApplicationProvider.getApplicationContext())
+  fun loadBannerAd_withNonActivityContext_callsInitializeUnityAds() {
+    mediationBannerAdConfiguration = initializeBannerAd(nonActivityContext)
+    whenever(mediationUtils.findClosestSize(eq(nonActivityContext), eq(AdSize.BANNER), any())) doReturn
+      AdSize.BANNER
 
     unityMediationAdapter.loadBannerAd(
       mediationBannerAdConfiguration,
       mediationBannerAdLoadCallback,
     )
 
-    val adErrorCaptor = argumentCaptor<AdError>()
-    verify(mediationBannerAdLoadCallback).onFailure(adErrorCaptor.capture())
-    val capturedError = adErrorCaptor.firstValue
-    assertThat(capturedError.code).isEqualTo(ERROR_CONTEXT_NOT_ACTIVITY)
-    assertThat(capturedError.message).isEqualTo(ERROR_MSG_NON_ACTIVITY)
-    assertThat(capturedError.domain).isEqualTo(ADAPTER_ERROR_DOMAIN)
+    verify(unityInitializer).initializeUnityAds(any(), any(), any())
   }
 
   @Test