don't use default value for array prop as svelte handles them in inconsistent way

Signed-off-by: Josh Hootman <[email protected]>

Author: HootDunk

frontend/src/lib/components/SelectedValues.svelte

@@ -1,7 +1,7 @@
 <script lang="ts">
 	import type { SelectedValue } from '$lib/services/Libre311/Libre311';
 
-	export let selectedValues: SelectedValue[] = [];
+	export let selectedValues: SelectedValue[];
 </script>
 
 {#each selectedValues as selectedValue}

frontend/src/lib/components/ServiceRequestDetails.svelte

@@ -58,10 +58,11 @@
 					<p class="text-sm">{serviceRequest.address}</p>
 				</div>
 
-				<div class="mb-1">
-					<SelectedValues selectedValues={serviceRequest.selected_values} />
-				</div>
-
+				{#if serviceRequest.selected_values}
+					<div class="mb-1">
+						<SelectedValues selectedValues={serviceRequest.selected_values} />
+					</div>
+				{/if}
 				{#if serviceRequest.description}
 					<div class="mb-1">
 						<strong class="text-base">{messages['serviceRequest']['description']}</strong>

frontend/src/lib/components/ServiceRequestUpdate.svelte

@@ -103,10 +103,7 @@
 	}
 
 	async function updateServiceRequest() {
-		if (agencyNameInput.value !== null || agencyNameInput.value !== undefined) {
-			let agency: string = new String(agencyNameInput.value).toString();
-			if (agency) agencyNameInput = optionalCoalesceNameValidator(createInput(agency));
-		}
+		agencyNameInput = optionalCoalesceNameValidator(agencyEmailInput);
 		agencyEmailInput = emailValidator(agencyEmailInput);
 		serviceNoticeInput = optionalCoalesceStringValidator(serviceNoticeInput);
 		statusNotesInput = optionalCoalesceStringValidator(statusNotesInput);
@@ -118,8 +115,6 @@
 			statusNotesInput.type
 		]);
 		if (resultSet.has('invalid')) {
-			// Refresh Inputs
-			agencyNameInput.value = '';
 			return;
 		}
 
@@ -175,9 +170,11 @@
 					<p class="text-sm">{serviceRequest.address}</p>
 				</div>
 
-				<div class="mb-1">
-					<SelectedValues selectedValues={serviceRequest.selected_values} />
-				</div>
+				{#if serviceRequest.selected_values}
+					<div class="mb-1">
+						<SelectedValues selectedValues={serviceRequest.selected_values} />
+					</div>
+				{/if}
 
 				{#if serviceRequest.description}
 					<div class="mb-1">