Skip to content

Commit 81aeb10

Browse files
committedMar 18, 2025
fix: make it compile with strictNullChecks set to true like in our config file
1 parent 37aeb62 commit 81aeb10

File tree

114 files changed

+541
-296
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

114 files changed

+541
-296
lines changed
 

‎package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,21 @@
3535
"scripts": {
3636
"start": "TZ=UTC node ./dist/server.js",
3737
"copy-templates": "copyfiles -u 1 src/mailtemplates/**/* dist/",
38-
"build:backend": "tsc --pretty --strictNullChecks false",
38+
"build:backend": "tsc --pretty",
3939
"build:frontend": "yarn --cwd ./frontend run build",
4040
"build:frontend:if-needed": "./scripts/build-frontend-if-needed.sh",
4141
"build": "yarn run clean && concurrently \"yarn:copy-templates\" \"yarn:build:frontend\" \"yarn:build:backend\"",
42-
"dev:backend": "TZ=UTC NODE_ENV=development tsc-watch --strictNullChecks false --onSuccess \"node dist/server-dev.js\"",
42+
"dev:backend": "TZ=UTC NODE_ENV=development tsc-watch --onSuccess \"node dist/server-dev.js\"",
4343
"dev:frontend": "wait-on tcp:4242 && yarn --cwd ./frontend run dev",
4444
"dev:frontend:cloud": "UNLEASH_BASE_PATH=/demo/ yarn run dev:frontend",
4545
"dev": "concurrently \"yarn:dev:backend\" \"yarn:dev:frontend\"",
4646
"prepare:backend": "concurrently \"yarn:copy-templates\" \"yarn:build:backend\"",
47-
"start:dev": "yarn run clean && TZ=UTC NODE_ENV=development tsc-watch --strictNullChecks false --onSuccess \"node dist/server-dev.js\"",
47+
"start:dev": "yarn run clean && TZ=UTC NODE_ENV=development tsc-watch --onSuccess \"node dist/server-dev.js\"",
4848
"db-migrate": "db-migrate --migrations-dir ./src/migrations",
4949
"lint": "biome check .",
5050
"lint:fix": "biome check . --write",
5151
"local:package": "del-cli --force build && mkdir build && cp -r dist docs CHANGELOG.md LICENSE README.md package.json build",
52-
"build:watch": "yarn run clean && tsc -w --strictNullChecks false",
52+
"build:watch": "tsc -w",
5353
"prepare": "husky && yarn --cwd ./frontend install && if [ ! -d ./dist ]; then yarn build; fi",
5454
"test": "NODE_ENV=test PORT=4243 node --trace-warnings node_modules/.bin/jest",
5555
"test:unit": "NODE_ENV=test PORT=4243 jest --testPathIgnorePatterns=src/test/e2e --testPathIgnorePatterns=dist",
@@ -60,7 +60,7 @@
6060
"test:coverage": "NODE_ENV=test PORT=4243 jest --coverage --testLocationInResults --outputFile=\"coverage/report.json\" --forceExit",
6161
"test:coverage:jest": "NODE_ENV=test PORT=4243 jest --silent --ci --json --coverage --testLocationInResults --outputFile=\"report.json\" --forceExit",
6262
"test:updateSnapshot": "NODE_ENV=test PORT=4243 jest --updateSnapshot",
63-
"seed:setup": "ts-node --compilerOptions '{\"strictNullChecks\": false}' src/test/e2e/seed/segment.seed.ts",
63+
"seed:setup": "ts-node src/test/e2e/seed/segment.seed.ts",
6464
"seed:serve": "UNLEASH_DATABASE_NAME=unleash_test UNLEASH_DATABASE_SCHEMA=seed yarn run start:dev",
6565
"clean": "del-cli --force dist",
6666
"heroku-postbuild": "cd frontend && yarn && yarn build",
@@ -220,7 +220,7 @@
220220
"supertest": "7.0.0",
221221
"ts-node": "10.9.2",
222222
"tsc-watch": "6.2.1",
223-
"typescript": "5.4.5",
223+
"typescript": "5.8.2",
224224
"wait-on": "^7.2.0"
225225
},
226226
"resolutions": {

‎src/lib/addons/datadog.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ interface DDRequestBody {
3232
export default class DatadogAddon extends Addon {
3333
private msgFormatter: FeatureEventFormatter;
3434

35-
flagResolver: IFlagResolver;
35+
declare flagResolver: IFlagResolver;
3636

3737
constructor(config: IAddonConfig) {
3838
super(definition, config);

0 commit comments

Comments
 (0)