From 0d48b74d8eb89cd6a1847d461fed785f9b0c48ad Mon Sep 17 00:00:00 2001 From: Ben Mitchinson Date: Fri, 11 Nov 2022 09:55:26 -0700 Subject: [PATCH 1/2] Added deprecated note about topLevelSelector in dataset.technical --- lib/smart_city/dataset/technical.ex | 1 + mix.exs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/smart_city/dataset/technical.ex b/lib/smart_city/dataset/technical.ex index fe50378..df9415e 100644 --- a/lib/smart_city/dataset/technical.ex +++ b/lib/smart_city/dataset/technical.ex @@ -36,6 +36,7 @@ defmodule SmartCity.Dataset.Technical do sourceUrl: String.t(), sourceType: not_required(String.t()), systemName: String.t(), + # deprecated topLevelSelector: not_required(String.t()) } diff --git a/mix.exs b/mix.exs index daae25a..d22a270 100644 --- a/mix.exs +++ b/mix.exs @@ -4,7 +4,7 @@ defmodule SmartCity.MixProject do def project do [ app: :smart_city, - version: "5.2.6", + version: "5.2.7", elixir: "~> 1.8", start_permanent: Mix.env() == :prod, deps: deps(), From da2e3fcde168efd65b634d65e1dd8cbca24bae10 Mon Sep 17 00:00:00 2001 From: Ben Mitchinson Date: Fri, 11 Nov 2022 09:58:10 -0700 Subject: [PATCH 2/2] Add mix version bump reminder to PR template --- .github/pull_request_template.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e3c5413..d9bd5f6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,8 @@ ## Reminders: -- [ ] If adding a new smart city data module, does it have a relevant test +- [ ] Did you up the mix.exs version? +- If adding a new smart city data module: + - [ ] does it have a relevant test - [ ] If a struct was added to an existing struct, was the parent `.new` method updated to convert keys to atoms -- [ ] If updating an existing module's type, was it's @moduledoc updated as well +- If updating an existing module's type: + - [ ] was it's @moduledoc updated as well